Warn about the old OCP\API::register construct for OCS #7917
Conversation
* Add sleep * Add log message Signed-off-by: Roeland Jago Douma <[email protected]>
|
|
||
| OC::$server->getRouter()->match('/ocs'.\OC::$server->getRequest()->getRawPathInfo()); | ||
|
|
||
| sleep(1); |
There was a problem hiding this comment.
Ah ... I guess we should then not do this (even if I proposed this), because the Android app for example uses it. On the other side: a good reason to migrate to v2 ;)
@tobiasKaminsky @marinofaggiana @mario @AndyScherzinger @camilasan @juliushaertl Opinions? cc'ing you for the clients
There was a problem hiding this comment.
Also happens on v2.php ;). Basically this only happens if the old route matches. The match throws an exception if it can't be found etc.
There was a problem hiding this comment.
So it only does the sleep if the request is one that matches an old OCP\API::register route
There was a problem hiding this comment.
We should migrate, yes. But please give us some time :-)
There was a problem hiding this comment.
Like i said. This in no way enforces you to use v2. (that is a different PR maybe :P)
There was a problem hiding this comment.
Exactly. I checked also all apps in the appstore and this is the only usage:
server/apps/files_external/appinfo/routes.php
Lines 65 to 68 in 0215b00
There was a problem hiding this comment.
Sorry was wrong - survey_client, survey_server and ocdownloader also use it:
There was a problem hiding this comment.
So what are the ocs path that are old?
Then I can check them on android.
There was a problem hiding this comment.
@tobiasKaminsky nothing for you to do here. This is only the implentation that needs to be adjusted. The endpoints should stay the same
Codecov Report
@@ Coverage Diff @@
## master #7917 +/- ##
============================================
- Coverage 51.23% 51.23% -0.01%
Complexity 24922 24922
============================================
Files 1604 1604
Lines 94982 94984 +2
Branches 1376 1376
============================================
Hits 48667 48667
- Misses 46315 46317 +2
|
|
Files external fix is already in #7923 |
|
Survery client in nextcloud/survey_client#72 |
|
I don't think I can fix ocdownloader as it also works on oC |
Signed-off-by: Roeland Jago Douma [email protected]