[stable13] If the preview is size 0 it is invalid #8030
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* delete it * throw a NotFound Exception - This should a proper 404 to the user - Next time it is then regenerated Signed-off-by: Roeland Jago Douma <[email protected]>
rullzer
added
enhancement
3. to review
rullzer
changed the title
MorrisJobke
approved these changes
Jan 24, 2018
nickvergessen
approved these changes
Jan 24, 2018
Codecov Report
@@ Coverage Diff @@
## stable13 #8030 +/- ##
=============================================
+ Coverage 51.23% 51.4% +0.16%
+ Complexity 24976 24975 -1
=============================================
Files 1607 1599 -8
Lines 95034 94709 -325
Branches 1376 1376
=============================================
- Hits 48691 48681 -10
+ Misses 46343 46028 -315 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of #7986
Signed-off-by: Roeland Jago Douma [email protected]