Skip to content

Conversation

@nickvergessen
Copy link
Member

Fix #879

@AndyScherzinger special values are <0:

/**
* @const \OCP\Files\FileInfo::SPACE_NOT_COMPUTED Return value for a not computed space value
* @since 8.0.0
*/
const SPACE_NOT_COMPUTED = -1;
/**
* @const \OCP\Files\FileInfo::SPACE_UNKNOWN Return value for unknown space value
* @since 8.0.0
*/
const SPACE_UNKNOWN = -2;
/**
* @const \OCP\Files\FileInfo::SPACE_UNKNOWN Return value for unlimited space
* @since 8.0.0
*/
const SPACE_UNLIMITED = -3;

I guess it would be nice to backport this, and since the patch is very little, it should also be save to do so.

@mention-bot
Copy link

@nickvergessen, thanks for your PR! By analyzing the annotation information on this pull request, we identified @LukasReschke, @tomneedham and @rullzer to be potential reviewers

@AndyScherzinger
Copy link
Member

AndyScherzinger commented Aug 16, 2016

Nice! @nickvergessen

One small issue:

* @const \OCP\Files\FileInfo::SPACE_UNKNOWN Return value for unlimited space
The comment is referring to the wrong constant (c&p...) 😉

👍 for the backport since then we won't have to implement a feature detection on Android and people would just have to upgrade e.g. to 9.0.54 (or something like that). Else we would have to restrict quotas being displayed to Nc 11...

@nickvergessen
Copy link
Member Author

Fixed the comment.

Btw one more thing, the endpoint is from the Provisioning API App, it is shipped and enabled by default, but it can be disabled. Just to be sure that you know this and have a fallback/error handling for the missing endpoint.

@AndyScherzinger
Copy link
Member

Uuuh, thanks for that comment 👍 Will check our code for that matter cc @tobiasKaminsky

@nickvergessen
Copy link
Member Author

@MorrisJobke @LukasReschke would be nice to get this one liner into 10 before the release

@AndyScherzinger
Copy link
Member

@MorrisJobke @LukasReschke That would be awesome! 👍

@rullzer
Copy link
Member

rullzer commented Aug 17, 2016

LGTM!

@rullzer rullzer force-pushed the issue-879-quota-unlimited-via-api branch from 36ba734 to a9f3606 Compare August 17, 2016 08:41
@rullzer
Copy link
Member

rullzer commented Aug 17, 2016

Rebased because of conflict

@LukasReschke
Copy link
Member

LGTM

@LukasReschke LukasReschke added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Aug 17, 2016
@nickvergessen
Copy link
Member Author

Backport is in #896

@rullzer rullzer merged commit e32d6d8 into master Aug 17, 2016
@rullzer rullzer deleted the issue-879-quota-unlimited-via-api branch August 17, 2016 09:51
GitHubUser4234 pushed a commit to GitHubUser4234/server that referenced this pull request Aug 30, 2016
…ited-via-api

Allow to retrieve the quota itself via the provisioning api
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to release Ready to be released and/or waiting for tests to finish enhancement feature: files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants