-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Allow to retrieve the quota itself via the provisioning api #890
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@nickvergessen, thanks for your PR! By analyzing the annotation information on this pull request, we identified @LukasReschke, @tomneedham and @rullzer to be potential reviewers |
|
Nice! @nickvergessen One small issue: server/lib/public/Files/FileInfo.php Line 56 in e321ecd
👍 for the backport since then we won't have to implement a feature detection on Android and people would just have to upgrade e.g. to 9.0.54 (or something like that). Else we would have to restrict quotas being displayed to Nc 11... |
|
Fixed the comment. Btw one more thing, the endpoint is from the Provisioning API App, it is shipped and enabled by default, but it can be disabled. Just to be sure that you know this and have a fallback/error handling for the missing endpoint. |
|
Uuuh, thanks for that comment 👍 Will check our code for that matter cc @tobiasKaminsky |
|
@MorrisJobke @LukasReschke would be nice to get this one liner into 10 before the release |
|
@MorrisJobke @LukasReschke That would be awesome! 👍 |
|
LGTM! |
36ba734 to
a9f3606
Compare
|
Rebased because of conflict |
|
LGTM |
|
Backport is in #896 |
…ited-via-api Allow to retrieve the quota itself via the provisioning api
Fix #879
@AndyScherzinger special values are
<0:server/lib/public/Files/FileInfo.php
Lines 45 to 59 in e321ecd
I guess it would be nice to backport this, and since the patch is very little, it should also be save to do so.