Remove "Help" link from personal sidebar #9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At the moment we want to hide the help link from the personal sidebar as it contains the original ownCloud documentation. Once we have our own documentation with our proper branding and so on we can reenable this.
Member
Author
|
Stable9 at #10 |
Member
|
great 👍 |
Member
|
👍 |
ghost
mentioned this pull request
8 tasks
8 tasks
8 tasks
9 tasks
zenlord
added a commit
to zenlord/server
that referenced
this pull request
Sep 5, 2022
# This is the 1st commit message: Patch from PR 24574 to view.js Signed-off-by: Vincent Van Houtte <[email protected]> # This is the commit message nextcloud#2: Patch from PR 24574 to lib/Connection.php Signed-off-by: Vincent Van Houtte <[email protected]> # This is the commit message nextcloud#3: Patch from PR 24574 to lib/Wizard.php Signed-off-by: Vincent Van Houtte <[email protected]> # This is the commit message nextcloud#4: Patch from PR 24574 to lib/LDAP.php (manually) Signed-off-by: Vincent Van Houtte <[email protected]> # This is the commit message nextcloud#5: Added a function usesLdapi() in Configuration.php and referenced that function throughout the PR Signed-off-by: Vincent Van Houtte <[email protected]> # This is the commit message nextcloud#6: Removed the questions I added in comments - https://github.com/nextcloud/server/pull/24574/files#r825732903 Signed-off-by: Vincent Van Houtte <[email protected]> # This is the commit message nextcloud#7: Changed the test as requested - https://github.com/nextcloud/server/pull/24574/files#r825726282 Signed-off-by: Vincent Van Houtte <[email protected]> # This is the commit message nextcloud#8: Changing return type from bool to int Signed-off-by: Vincent Van Houtte <[email protected]> # This is the commit message nextcloud#9: Changing return type of usesLdapi() to bool and adapting references Signed-off-by: Vincent Van Houtte <[email protected]>
8 tasks
9 tasks
9 tasks
9 tasks
9 tasks
9 tasks
9 tasks
9 tasks
9 tasks
Closed
8 tasks
alpapan
added a commit
to alpapan/nextcloud-server
that referenced
this pull request
Feb 7, 2024
fixes this error caused when system has usernames that are purely numeric. An unhandled exception has been thrown: Error: Object of class OCA\User_LDAP\User\User could not be converted to string in /var/www/nextcloud/apps/user_ldap/lib/User_LDAP.php:312 Stack trace: #0 [internal function]: OCA\User_LDAP\User_LDAP->userExistsOnLDAP() nextcloud#1 /var/www/nextcloud/apps/user_ldap/lib/User_Proxy.php(126): call_user_func_array() nextcloud#2 /var/www/nextcloud/apps/user_ldap/lib/Proxy.php(140): OCA\User_LDAP\User_Proxy->walkBackends() nextcloud#3 /var/www/nextcloud/apps/user_ldap/lib/User_Proxy.php(262): OCA\User_LDAP\Proxy->handleRequest() nextcloud#4 /var/www/nextcloud/apps/user_ldap/lib/User_Proxy.php(239): OCA\User_LDAP\User_Proxy->userExistsOnLDAP() nextcloud#5 /var/www/nextcloud/lib/private/User/Manager.php(168): OCA\User_LDAP\User_Proxy->userExists() nextcloud#6 /var/www/nextcloud/apps/files_fulltextsearch/lib/Service/FilesService.php(399): OC\User\Manager->get() nextcloud#7 /var/www/nextcloud/apps/files_fulltextsearch/lib/Service/FilesService.php(226): OCA\Files_FullTextSearch\Service\FilesService->initFileSystems() nextcloud#8 /var/www/nextcloud/apps/files_fulltextsearch/lib/Provider/FilesProvider.php(246): OCA\Files_FullTextSearch\Service\FilesService->getChunksFromUser() nextcloud#9 /var/www/nextcloud/apps/fulltextsearch/lib/Service/IndexService.php(174): OCA\Files_FullTextSearch\Provider\FilesProvider->generateChunks() nextcloud#10 /var/www/nextcloud/apps/fulltextsearch/lib/Command/Index.php(403): OCA\FullTextSearch\Service\IndexService->indexProviderContentFromUser() nextcloud#11 /var/www/nextcloud/apps/fulltextsearch/lib/Command/Index.php(280): OCA\FullTextSearch\Command\Index->indexProvider() nextcloud#12 /var/www/nextcloud/3rdparty/symfony/console/Command/Command.php(298): OCA\FullTextSearch\Command\Index->execute() nextcloud#13 /var/www/nextcloud/core/Command/Base.php(177): Symfony\Component\Console\Command\Command->run() nextcloud#14 /var/www/nextcloud/3rdparty/symfony/console/Application.php(1040): OC\Core\Command\Base->run() nextcloud#15 /var/www/nextcloud/3rdparty/symfony/console/Application.php(301): Symfony\Component\Console\Application->doRunCommand() nextcloud#16 /var/www/nextcloud/3rdparty/symfony/console/Application.php(171): Symfony\Component\Console\Application->doRun() nextcloud#17 /var/www/nextcloud/lib/private/Console/Application.php(206): Symfony\Component\Console\Application->run() nextcloud#18 /var/www/nextcloud/console.php(100): OC\Console\Application->run() nextcloud#19 /var/www/nextcloud/occ(11): require_once('...') nextcloud#20 {main}roopico /var/www/nextcloud/apps/user_ldap/lib/User/OfflineUser.phparch:index Signed-off-by: Alexie Papanicolaou <[email protected]>
8 tasks
8 tasks
8 tasks
8 tasks
8 tasks
8 tasks
8 tasks
8 tasks
8 tasks
miaulalala
added a commit
that referenced
this pull request
Dec 16, 2025
# This is the 1st commit message: feat(snowflake): extend Entity class to support snowflakes RFC: extending the Entity class to support snoflake IDs automagically Good ides - yes / no? Benefits: - every entity that supports snowflake IDs can automagically handle them by implementing the `SnowflakeAwareEntity` instead of the regular `Entity` - No adding IGenerator / IDecoder in every entity class - centralised method support for `createdAt`, `setId`, and anything else we would like to offer separately - get entire decoded snowflake id from the entity Drawbacks: - Will it work the way I think it should? Signed-off-by: Anna Larch <[email protected]> # The commit message #2 will be skipped: # fixup! feat(snowflake): extend Entity class to support snowflakes # The commit message #3 will be skipped: # fixup! feat(snowflake): extend Entity class to support snowflakes # The commit message #4 will be skipped: # fixup! feat(snowflake): extend Entity class to support snowflakes # The commit message #5 will be skipped: # fixup! feat(snowflake): extend Entity class to support snowflakes # The commit message #6 will be skipped: # fixup! feat(snowflake): extend Entity class to support snowflakes # The commit message #7 will be skipped: # fixup! feat(snowflake): extend Entity class to support snowflakes # The commit message #8 will be skipped: # fixup! feat(snowflake): extend Entity class to support snowflakes # The commit message #9 will be skipped: # fixup! feat(snowflake): extend Entity class to support snowflakes # The commit message #10 will be skipped: # fixup! feat(snowflake): extend Entity class to support snowflakes # The commit message #11 will be skipped: # fixup! feat(snowflake): extend Entity class to support snowflakes # The commit message #12 will be skipped: # fixup! feat(snowflake): extend Entity class to support snowflakes # The commit message #13 will be skipped: # fixup! feat(snowflake): extend Entity class to support snowflakes # The commit message #14 will be skipped: # fixup! feat(snowflake): extend Entity class to support snowflakes # The commit message #15 will be skipped: # fixup! feat(snowflake): extend Entity class to support snowflakes # The commit message #16 will be skipped: # fixup! feat(snowflake): extend Entity class to support snowflakes
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment we want to hide the help link from the personal sidebar as it contains the original ownCloud documentation.
Once we have our own documentation with our proper branding and so on we can reenable this.
@jospoortvliet @karlitschek @jancborchardt @MorrisJobke As discussed 🚀