Skip to content

Fix icons on App page in FF #905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MorrisJobke merged 6 commits into from
Aug 17, 2016
Merged

Fix icons on App page in FF #905

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
960d0d1
Filter can't be named invert in FF
rullzer Aug 17, 2016
1444c1d
Introduce weird hack for Firefox
MorrisJobke Aug 17, 2016
314b400
Remove hack
rullzer Aug 17, 2016
ba4633b
Add viewBox to app icons
rullzer Aug 17, 2016
bded787
Empty tags are not allowed for image and feColorMatrix in IE11 and below
MorrisJobke Aug 17, 2016
28c192c
Fix null reference in IE
MorrisJobke Aug 17, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Introduce weird hack for Firefox 
* everything is 4 times as big (doubled width and doubled height)
  • Loading branch information
@MorrisJobke
MorrisJobke committed Aug 17, 2016
commit 1444c1d3456b1f9b7179d1be2c7496a84bbc8fdd
5 changes: 5 additions & 0 deletions settings/js/apps.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,6 +234,11 @@ OC.Settings.Apps = OC.Settings.Apps || {

imageUrl : function (url, appfromstore) {
var img = '<svg width="72" height="72" viewBox="0 0 72 72">';
// weird hack because in Firefox everything is 4 times as big (doubled in width and doubled in height)
// TODO: replace this with a proper solution
Copy link
Member

@blizzz blizzz Aug 17, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we have todos as issues instead, pls?

Copy link
Member

@MorrisJobke MorrisJobke Aug 17, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will create it

Copy link
Member

@MorrisJobke MorrisJobke Aug 17, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#908

if($.browser.mozilla) {
img = '<svg width="72" height="72" viewBox="0 0 36 36">';
}
if (appfromstore) {
img += '<image x="0" y="0" width="72" height="72" preserveAspectRatio="xMinYMin meet" xlink:href="' + url + '" class="app-icon" /></svg>';
} else {
Expand Down