Move Tags/Controller over to a real Controller #958
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rullzer, thanks for your PR! By analyzing the annotation information on this pull request, we identified @tanghus, @nickvergessen and @MorrisJobke to be potential reviewers |
Member
Author
|
Lets deprecate this internal route (How do we signal this?) |
Member
|
Announce in the dev forum |
core/Controller/TagsController.php
Outdated
| @@ -0,0 +1,232 @@ | |||
| <?php | |||
| /** | |||
| * | |||
* AppFramework FTW
Member
|
LGTM |
Member
Author
|
So it seems in the old code the route /tags/files/ids Throws an exception. I vote again to remove. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up of #947
This moves the tags 'controller' over to a real controller and leverages all the DI the AppFramework gives us.
There were no tests. And are no tests so far. If somebody desperatly wants them feel free to add.
CC: @nickvergessen @MorrisJobke @LukasReschke @icewind1991
P.s. I still vote to kill this off in time.