Fix #9864: Decrease $maxDelay in Throttler.php

[wiyh12nf89x]

Fix #9864

Signed-off-by: Mark Berezovsky [email protected]

[codecov]

Codecov Report

Merging #9875 into master will not change coverage.
The diff coverage is 0%.

@@            Coverage Diff            @@
##             master    #9875   +/-   ##
=========================================
  Coverage     51.92%   51.92%           
  Complexity    25787    25787           
=========================================
  Files          1637     1637           
  Lines         95453    95453           
  Branches       1318     1318           
=========================================
  Hits          49566    49566           
  Misses        45887    45887

Impacted Files	Coverage Δ	Complexity Δ
lib/private/Security/Bruteforce/Throttler.php	38.13% <0%> (ø)	27 <0> (ø)	⬇️
apps/files_trashbin/lib/Expiration.php	90.32% <0%> (-1.62%)	29% <0%> (ø)
apps/files_trashbin/lib/Trashbin.php	72.7% <0%> (+0.24%)	136% <0%> (ø)	⬇️

[MorrisJobke]

Makes sense 👍

[brunob]

Hi, this fix has not been merged to branch 13, and i can confirm that it fixes the problem of NC client sync with NC server 13.0.11 (like described in some of the issues pointed #9864 (comment)). Could this patch be merged to branch 13 ?

[MorrisJobke]

Hi, this fix has not been merged to branch 13, and i can confirm that it fixes the problem of NC client sync with NC server 13.0.11 (like described in some of the issues pointed #9864 (comment)). Could this patch be merged to branch 13 ?

13 is close to end of life (last release in ~1,5 week). We try to minimize the amount of back ports to those and focus on security related backports. We highly recommend to upgrade to Nextcloud 14+.

[wiyh12nf89x]

Hi, this fix has not been merged to branch 13, and i can confirm that it fixes the problem of NC client sync with NC server 13.0.11 (like described in some of the issues pointed #9864 (comment)). Could this patch be merged to branch 13 ?

Anyways, you can just manually change the variable value after you have installed/upgraded the server:
sed -i -- 's/\$maxDelay = 30/\$maxDelay = 25/g' /path-to-server/lib/private/Security/Bruteforce/Throttler.php

[brunob]

@MorrisJobke nice point, but since it will be the last release of this branch it could be the opportunity to prevent a blocking client sync bug. Anyway, thx for the answer ;)

[MorrisJobke]

/backport to stable13

[MorrisJobke]

@MorrisJobke nice point, but since it will be the last release of this branch it could be the opportunity to prevent a blocking client sync bug. Anyway, thx for the answer ;)

Fine with me if it is a pure cherry-pick :)

[backportbot-nextcloud]

backport to stable13 in #14224