-
Notifications
You must be signed in to change notification settings - Fork 65
Fix Memory #240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Memory #240
Conversation
Cast swapFree to integer to fix typeerror. Fix total memory to use hw.realmem Signed-off-by: Matthew Wener <[email protected]> Signed-off-by: Matthew Wener <[email protected]>
|
I don't see how to run into a type error? swapTotal is casted the line before and the free space is also casted. Mind to add an example? |
|
serverinfo/tests/lib/FreeBSDTest.php Line 57 in 741936a
serverinfo/tests/lib/FreeBSDTest.php Line 75 in 741936a
Change |
From my logs |
|
Mind to share the output of |
|
|
Ah. The closing bracket is wrong in the above code. It should be Mind to update your patch and adjust the tests for |
Signed-off-by: Matthew Wener <[email protected]> Signed-off-by: Matthew Wener <[email protected]>
Please update this test case as well. |
|
/backport to stable20 |
Signed-off-by: Matthew Wener <[email protected]>
kesselb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 👍
|
The backport to stable20 failed. Please do this backport manually. |
* Fix Memory Cast swapFree to integer to fix typeerror. Fix total memory to use hw.realmem Signed-off-by: Matthew Wener <[email protected]> Signed-off-by: Matthew Wener <[email protected]> * Prevent float in swapinfo and update tests for hw.realmem Signed-off-by: Matthew Wener <[email protected]> Signed-off-by: Matthew Wener <[email protected]> * Update testGetMemoryNoSwapinfo to hw.realmem Signed-off-by: Matthew Wener <[email protected]> (cherry picked from commit 49952d2)
* Fix Memory Cast swapFree to integer to fix typeerror. Fix total memory to use hw.realmem Signed-off-by: Matthew Wener <[email protected]> Signed-off-by: Matthew Wener <[email protected]> * Prevent float in swapinfo and update tests for hw.realmem Signed-off-by: Matthew Wener <[email protected]> Signed-off-by: Matthew Wener <[email protected]> * Update testGetMemoryNoSwapinfo to hw.realmem Signed-off-by: Matthew Wener <[email protected]> (cherry picked from commit 49952d2) Signed-off-by: Daniel Kesselberg <[email protected]>
Cast swapFree to integer to fix typeerror.
Fix total memory to use hw.realmem