Skip to content

[stable20] Fix FreeBSD Interface Exception #252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kesselb merged 3 commits into from
Oct 12, 2020
Merged

[stable20] Fix FreeBSD Interface Exception #252

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
78a9385
Fix FreeBSD Exception (null not string returned from speed/duplex)
ConstrictM Oct 11, 2020
2f31af2
Create a default active for a null status
ConstrictM Oct 11, 2020
df5cb8d
Switch null check to isset
ConstrictM Oct 12, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Switch null check to isset 
Signed-off-by: Matthew Wener <[email protected]>
  • Loading branch information
@ConstrictM @backportbot
ConstrictM authored and backportbot[bot] committed Oct 12, 2020
commit df5cb8daa10e36c37b4f515038ff7d2e0261799e
6 changes: 3 additions & 3 deletions lib/OperatingSystems/FreeBSD.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,13 +186,13 @@ public function getNetworkInterfaces() {
$iface['mac'] = implode(' ', $mac[0]);
$iface['speed'] = $speed[0];

if ($status[0] !== null) {
if (isset($status[0])) {
$iface['status'] = $status[0];
} else {
$iface['status'] = 'active';
}

if ($iface['speed'] !== null) {
if (isset($iface['speed'])) {
if (strpos($iface['speed'], 'G')) {
$iface['speed'] = rtrim($iface['speed'], 'G');
$iface['speed'] = $iface['speed'] . ' Gbps';
Expand All @@ -203,7 +203,7 @@ public function getNetworkInterfaces() {
$iface['speed'] = 'unknown';
}

if ($duplex[0] !== null) {
if (isset($duplex[0])) {
$iface['duplex'] = 'Duplex: ' . $duplex[0];
} else {
$iface['duplex'] = '';
Expand Down