Bugfix for #168: basedir restriction and handling speed=-1 result #257
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kesselb
approved these changes
Dec 2, 2020
kesselb
requested changes
Dec 2, 2020
Collaborator
kesselb
left a comment
kesselb
left a comment
There was a problem hiding this comment.
Please adjust the code like suggested and sign off the commits. Thanks!
sausix
force-pushed
the
bugfix/168/basedir-sys-class-net
branch
2 times, most recently
from
7d22a77 to
c51ded1
Compare
…esult Signed-off-by: Adrian Sausenthaler <[email protected]>
Signed-off-by: Adrian Sausenthaler <[email protected]>
Signed-off-by: Adrian Sausenthaler <[email protected]>
sausix
force-pushed
the
bugfix/168/basedir-sys-class-net
branch
from
c51ded1 to
4ff3e3d
Compare
Collaborator
|
cc @tuxmaster5000 @HigH-HawK mind to test? |
Contributor
|
Release 19.0.6: Changes look good to me 👍 |
Contributor
|
/rebase |
This was referenced Aug 12, 2022
This was referenced Aug 24, 2022
This was referenced Sep 6, 2022
This was referenced Sep 20, 2022
Collaborator
|
Thanks for your pull request 👍 I assume the logic to filter out If you still see the error with speed -1 please submit a new pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #168 with scandir instead of glob.
Minor fix for better handling
/sys/class/net/*/speedreturning-1.