Skip to content

Added 7 and 30 day values to "Active Users" stats graph #267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
akhil1508 wants to merge 27 commits into from
Closed

Added 7 and 30 day values to "Active Users" stats graph #267

akhil1508 wants to merge 27 commits into from

Conversation

@akhil1508
Copy link

@akhil1508 akhil1508 commented Jan 11, 2021 •
edited
Loading

  • Added 7 and 30 day values to the "Active users" stats graph (returned through "lib/SessionStatistics.php" and used in frontend in "js/script.js)
  • Modified unit tests accordingly to test that new values are correctly returned
  • Package "nextcloud/coding-standard" updated to "^0.4.0" from "^0.3.0"(PHPLint refuses to install correctly with 0.3.0 in the checks otherwise)

@akhil1508 akhil1508 force-pushed the frontend_and_test_fixes branch from de92f15 to 3c9c9b6 Compare January 12, 2021 08:37
ConstrictM and others added 26 commits January 12, 2021 14:07
@ConstrictM @akhil1508
Fix FreeBSD Exception (null not string returned from speed/duplex)
9090ed2 
Signed-off-by: Matthew Wener <[email protected]>
Signed-off-by: akhil <[email protected]>
@ConstrictM @akhil1508
Create a default active for a null status
52e1da8 
Signed-off-by: Matthew Wener <[email protected]>
Signed-off-by: akhil <[email protected]>
@ConstrictM @akhil1508
Switch null check to isset
0e29405 
Signed-off-by: Matthew Wener <[email protected]>
Signed-off-by: akhil <[email protected]>
@nextcloud-bot @akhil1508
[tx-robot] updated from transifex
833998b 
Signed-off-by: akhil <[email protected]>
@akhil1508
Added frontend fix for active user statistics
2bb93ee 
Signed-off-by: akhil <[email protected]>
@nextcloud-bot @akhil1508
[tx-robot] updated from transifex
8099caf 
Signed-off-by: akhil <[email protected]>
@nickvergessen @akhil1508
Add OCI github action
c865545 
Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: akhil <[email protected]>
@nextcloud-bot @akhil1508
[tx-robot] updated from transifex
afdb629 
Signed-off-by: akhil <[email protected]>
@nextcloud-bot @akhil1508
[tx-robot] updated from transifex
90c4b47 
Signed-off-by: akhil <[email protected]>
@juliusknorr @akhil1508
Properly fetch oracle database information
861cd9d 
Signed-off-by: Julius Härtl <[email protected]>
Signed-off-by: akhil <[email protected]>
@nextcloud-bot @akhil1508
[tx-robot] updated from transifex
3f1e915 
Signed-off-by: akhil <[email protected]>
@nickvergessen @akhil1508
Fix MySQL database size calculation
e4efb47 
Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: akhil <[email protected]>
@nextcloud-bot @akhil1508
[tx-robot] updated from transifex
1c7ccf5 
Signed-off-by: akhil <[email protected]>
@nextcloud-bot @akhil1508
[tx-robot] updated from transifex
a5f9e93 
Signed-off-by: akhil <[email protected]>
@akhil1508
Added test modifications
9c56140 
Signed-off-by: akhil <[email protected]>
@akhil1508
Changed count assertion to assert 5 instead of 3
0303e43 
Signed-off-by: akhil <[email protected]>
@akhil1508
Lint
773a5fb 
Signed-off-by: akhil <[email protected]>
@akhil1508
Update SessionStatisticsTest.php
c7bf503 
Signed-off-by: akhil <[email protected]>
@akhil1508
Update SessionStatisticsTest.php
530b24e 
Signed-off-by: akhil <[email protected]>
@akhil1508
Fix for lint check
6aa0f65 
Signed-off-by: akhil <[email protected]>
@akhil1508
Ran composer update
f56ab1c 
Signed-off-by: akhil <[email protected]>
@akhil1508
Trying coding standard v0.4.0
bd80839 
Signed-off-by: akhil <[email protected]>
@akhil1508
Update SessionStatisticsTest.php
7e0269a 
Signed-off-by: akhil <[email protected]>
@akhil1508
Fixes linting
7f1e877 
Signed-off-by: akhil <[email protected]>
@akhil1508
Re-added last 30 days
72f48a1 
Signed-off-by: akhil <[email protected]>
@akhil1508
cs fixed
1575062 
Signed-off-by: akhil <[email protected]>
@akhil1508 akhil1508 force-pushed the frontend_and_test_fixes branch from 3c9c9b6 to 1575062 Compare January 12, 2021 08:37
@akhil1508 akhil1508 changed the title Frontend and test fixes Added 7 and 30 day values to "Active Users" stats graph Jan 18, 2021
@arnauvp
Copy link

arnauvp commented Jan 29, 2021

Ping

@J0WI
Copy link
Contributor

J0WI commented Feb 17, 2021

The performance is already pretty bad on large instances. Most likely due share statistics but better safe than sorry.

@arnauvp
Copy link

arnauvp commented Feb 19, 2021

On our instance, the serverinfo/api/v1/info?format=json call takes up to 5.5 seconds. The DB query to fetch unique users in last 30 days takes ~400ms before it's cached.

@blizzz blizzz added this to the Nextcloud 25 milestone Apr 21, 2022
This was referenced Aug 12, 2022
Merged
Merged
This was referenced Aug 24, 2022
Merged
Merged
This was referenced Sep 6, 2022
Merged
Merged
@skjnldsv skjnldsv mentioned this pull request Sep 15, 2022
Merged
This was referenced Sep 20, 2022
Closed
Merged
@blizzz blizzz modified the milestones: Nextcloud 25, Nextcloud 26 Sep 22, 2022
@nickvergessen
Copy link
Member

nickvergessen commented Jan 25, 2023

Needs a major overhaul after #420

Want to have a look?

@nickvergessen nickvergessen removed this from the Nextcloud 26 milestone Jan 25, 2023
@akhil1508 akhil1508 closed this Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

2. developing enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@akhil1508 @arnauvp @J0WI @nickvergessen @blizzz @ConstrictM @nextcloud-bot @juliusknorr