Improve gateway information parsing #331
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I already did something similar (but not reviewed yet): #271 |
1. Fix FreeBSD-specific parsing that missed any digits of the last IP octet more than a single digit. 2. Support IPv6 addresses as the default gateway 3. Parse multiple default gateways in a dual-stack IPv4/IPv6 system 4. Switch DefaultOs.php to use `preg_match_all()` instead of a shell pipeline for parsing. Signed-off-by: Ross Williams <[email protected]>
overhacked
force-pushed
the
fix_freebsd_gateway_ip
branch
from
dd780c5 to
560e87e
Compare
Contributor
|
The other PR was merged. Can you rebase and check if you have other things to fix in your PR? |
This was referenced Aug 12, 2022
This was referenced Aug 24, 2022
This was referenced Sep 6, 2022
This was referenced Sep 20, 2022
This was referenced May 3, 2023
Collaborator
|
Thanks for your pull request 👍 I'm closing the pull request due to the lack of activity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
of the last IP octet more than a single digit.
IPv4/IPv6 system
preg_match_all()instead of a shell pipeline for parsing.