Update OCA\ServerInfo\OperatingSystems::getNetworkInterfaces() #332
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tflidd
approved these changes
Nov 1, 2021
Contributor
|
@nickvergessen what can we do about the tests that don't complete after 3 months? |
Member
|
Basically the branch needs to be on our repo |
Contributor
|
on this pull request it works without the branch being in the nextcloud repo: |
Signed-off-by: Raymond Hackley <[email protected]>
Contributor
Author
I rebased on latest master and I got this. |
Member
|
Now the option was visible. Approved the run |
CarlSchwan
approved these changes
Jan 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change 1
Fix bug when
cat /sys/class/net/<interface>/speedreturns-1Change 2
Support
Gbpsas speed unit whencat /sys/class/net/<interface>/speed>= 1000Signed-off-by: Raymond Hackley [email protected]