Fix appearance and some bugs

[Valdnet]

Improved appearance and repair of text strings.

Before change:

After change:

In Polish 😁:

Solves Issue: #324 and #232.

---

Before change:

After change:

---

Before change:

After change:

---

Before change:

After change:

---

Before change:

After change:

---

Before change:

After change:

---

Before change:

After change:

Signed-off-by: Valdnet [email protected]

[Valdnet]

@nickvergessen @juliushaertl @kesselb @Rello I am asking everyone for approval. It would be nice to add changes to a future version of NC 23.

[nickvergessen]

Suggested change

	<p><?php p($l->t('Operating System').':'); ?> <strong id="numFilesStorage"><?php p($_['osname']); ?></strong></p>
	<p><?php p($l->t('CPU').':'); ?>
	<p><?php p($l->t('Operating System:')); ?> <strong id="numFilesStorage"><?php p($_['osname']); ?></strong></p>
	<p><?php p($l->t('CPU:')); ?>

etc so french translators can add their space before the colon

[Valdnet]

Corrected. Please approve and merge 😉.

[Valdnet]

@nickvergessen @juliushaertl @kesselb @Rello I am asking everyone for approval 😉.

[Valdnet]

@tcitworld Thanks for checking. I added a condition for "SWAP". Please approval 😉.

[jancborchardt]

Looks much better design-wise, nice detail fixes! :)

[Valdnet]

Thanks 😉.

[Valdnet]

@nickvergessen Please do a manual backport for NC 22, 21 and 20. Bot won't do this 😬.

And is it still possible to attach the changes to NC23?

[nickvergessen]

I won't do that. Not my area.

[Valdnet]

@juliushaertl Please do a manual backport for NC 22, 21 and 20. Bot won't do this 😬.

And is it still possible to attach the changes to NC23?

[come-nc]

The colon should always be part of the translated string, as it may be changed by the translation.
For instance in French a (small nonbreakable) space is expected before a double punctuation like a colon.

[Valdnet]

Yes, you are absolutely right 👍, but in this case an exception is made, because using a colon in this PHP code with an entire text string means that the entire text string in the application is not displayed 😬. This was one of the problems that this change arose. I haven't found any other sensible solution to this problem, which doesn't mean it needs to be corrected.
I would like to ask developers who know more about PHP programming to look at this code, and maybe they will find a solution, and will be happy to implement it, so that French translators can correctly translate these text strings.

@nickvergessen could you have a look at it and advise us something?

@come-nc Unless you know the solution to this problem?

[nickvergessen]

I already mentioned it here that this is necessary: https://github.com/nextcloud/serverinfo/pull/333/files#r752009811

[nickvergessen]

Lemme checkout the branch and move it in, to see what breaks but it makes no sense to break

[Valdnet]

I already mentioned it here that this is necessary: https://github.com/nextcloud/serverinfo/pull/333/files#r752009811

@nickvergessen Yes, I know this and I remember it, but after using a colon text string, I do not know why, but this text string is not displayed at all. This was a problem before. Cannot use a colon in a text string in PHP?

[nickvergessen]

Fix nextcloud/server#32155