Skip to content

Check if shell_exec response is not false #391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
szaimen merged 1 commit into from
Sep 5, 2022
Merged

Check if shell_exec response is not false #391

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Check if shell_exec response is not false 
Signed-off-by: Daniel Kesselberg <[email protected]>
  • Loading branch information
@kesselb
kesselb committed Sep 3, 2022
commit e8957e389e6bbb83898c6061545131ea1ddeeadf
2 changes: 1 addition & 1 deletion lib/OperatingSystems/DefaultOs.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,7 +246,7 @@ protected function readContent(string $filename): string {

protected function executeCommand(string $command): string {
$output = @shell_exec(escapeshellcmd($command));
if ($output === null || $output === '') {
if ($output === false || $output === null || $output === '') {
throw new \RuntimeException('No output for command: "' . $command . '"');
}
return $output;
Expand Down