Skip to content

Visual fixes and improvements #711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kesselb merged 7 commits into from
Dec 2, 2024
Merged

Visual fixes and improvements #711

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
e2c1d33
Updated smothie.js to latest version
Malex14 Nov 16, 2024
51fc3bf
update chart size when dpr changes
Malex14 Nov 16, 2024
1fdb35c
improved chart visuals and added tooltip with additional information
Malex14 Nov 16, 2024
30bf912
fixed css responsiveness issues, fixed icon positions, reenabled the …
Malex14 Nov 16, 2024
65da59c
fixed lint issues, added getCpuCount function to the dummy os
Malex14 Nov 16, 2024
c04c3a5
get cpu count using /proc/cpuinfo on linux
Malex14 Nov 25, 2024
eebc704
use the same default cpu count placeholder for FreeBSD and Linux
Malex14 Nov 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
use the same default cpu count placeholder for FreeBSD and Linux 
Signed-off-by: Malex14 <[email protected]>
  • Loading branch information
@Malex14
Malex14 committed Nov 25, 2024
commit eebc704ad200e5b26b6903adb2709c2f7e246190
2 changes: 1 addition & 1 deletion lib/OperatingSystems/FreeBSD.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ public function getCpuName(): string {
}

public function getCpuCount(): int {
$numCpu = 1; // this should be a save default
$numCpu = -1;

try {
$numCpu = intval($this->executeCommand('sysctl -n hw.ncpu')); //TODO: this should be tested if it actually works on FreeBSD
Copy link
Collaborator

@kesselb kesselb Dec 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That yields the expected result for my cpu.

Copy link
Contributor Author

@Malex14 Malex14 Dec 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok 👍 , then I will remove the comment

Expand Down
Loading