Follow-up(Edit message) #11451
Merged
Follow-up(Edit message) #11451
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/components/MessagesList/MessagesGroup/Message/MessageButtonsBar/MessageButtonsBar.vue
Outdated
Show resolved
Hide resolved
src/components/MessagesList/MessagesGroup/Message/MessageButtonsBar/MessageButtonsBar.vue
Outdated
Show resolved
Hide resolved
DorraJaouad
force-pushed
the
feat/11206/edit-message-mentions
branch
from
3315110 to
de32f0b
Compare
Antreesy
reviewed
Jan 29, 2024
Contributor
Antreesy
left a comment
Antreesy
left a comment
There was a problem hiding this comment.
Nice in general, some technical nitpicks:
src/components/MessagesList/MessagesGroup/Message/MessageButtonsBar/MessageButtonsBar.vue
Outdated
Show resolved
Hide resolved
src/components/MessagesList/MessagesGroup/Message/MessageButtonsBar/MessageButtonsBar.vue
Show resolved
Hide resolved
src/components/MessagesList/MessagesGroup/Message/MessageButtonsBar/MessageButtonsBar.vue
Show resolved
Hide resolved
Signed-off-by: DorraJaouad <[email protected]>
Signed-off-by: DorraJaouad <[email protected]>
DorraJaouad
force-pushed
the
feat/11206/edit-message-mentions
branch
from
de32f0b to
c2a087b
Compare
Antreesy
reviewed
Jan 30, 2024
src/components/MessagesList/MessagesGroup/Message/MessageButtonsBar/MessageButtonsBar.vue
Outdated
Show resolved
Hide resolved
Antreesy
reviewed
Jan 30, 2024
DorraJaouad
force-pushed
the
feat/11206/edit-message-mentions
branch
5 times, most recently
from
21b37c3 to
f6e7f1d
Compare
Signed-off-by: DorraJaouad <[email protected]>
Signed-off-by: DorraJaouad <[email protected]>
DorraJaouad
force-pushed
the
feat/11206/edit-message-mentions
branch
from
f6e7f1d to
c0d7bad
Compare
Antreesy
approved these changes
Jan 31, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
Remark
Mention hint when editing ( NcNoteCard ) will be shown if the message has
@initially (before editing it). Otherwise, we will need to compute diff every time the text is edited (not worth it and can be large for long messages)🖌️ UI Checklist
🖼️ Screenshots / Screencasts
Newly added
🚧 Tasks
🏁 Checklist