Skip to content

Conversation

@Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Mar 1, 2024

☑️ Resolves

Let's assume we have messagesGroup {6} from one author with ids [6..10]
When fetching old messages, new group {1} is compiled for the same author, and covers messages [1..10]
As starting id is different, groups won't match and both remain in the list

🖌️ UI Checklist

Follow-up: move grouping logic to composable and add test coverage?

🏁 Checklist

  • 🌏 Tested with Chrome, Firefox and Safari or should not be risky to browser differences
  • 🖥️ Tested with Desktop client or should not be risky for it
  • ⛑️ Tests are included or not possible

@Antreesy Antreesy added this to the 💞 Next Major (29) milestone Mar 1, 2024
@Antreesy Antreesy requested a review from DorraJaouad March 1, 2024 17:28
@Antreesy Antreesy self-assigned this Mar 1, 2024
@Antreesy Antreesy force-pushed the fix/noid/message-old-update branch from d9a29a2 to 8a9dcfe Compare March 1, 2024 18:01
Copy link
Contributor

@DorraJaouad DorraJaouad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch btw

@Antreesy Antreesy force-pushed the fix/noid/message-old-update branch from 8a9dcfe to 30fd214 Compare March 1, 2024 22:56
Copy link
Contributor

@DorraJaouad DorraJaouad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested 😨

@Antreesy Antreesy merged commit 5694e01 into main Mar 2, 2024
@Antreesy Antreesy deleted the fix/noid/message-old-update branch March 2, 2024 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants