fix(dashboard): Fix dashboard when the last message of a chat expired #12302
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joas Schilling <[email protected]>
nickvergessen
added
3. to review
feature: chat 💬
Member
Author
|
/backport to stable29 |
Antreesy
approved these changes
May 7, 2024
Contributor
Antreesy
left a comment
Antreesy
left a comment
There was a problem hiding this comment.
Looks good. Maybe we could consider to use t('spreed', 'No messages') as a placeholder for such cases?
Member
Author
|
Something for later, would like to improve the handling to show the last mention first, instead of "You were mentioned" and then we can afterwards think about how to handle all the cases when the messages are not there anymore. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
🛠️ API Checklist
🏁 Checklist
docs/has been updated or is not required