Skip to content

Conversation

@hamza221
Copy link
Contributor

@hamza221 hamza221 commented Jun 13, 2024

☑️ Resolves

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🏚️ Before 🏡 After
image image

🚧 Tasks

  • ...

🏁 Checklist

Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good! Let's wait for server PR to be merged, then we'll test it again
When possible, please provide a screenshot, if design team would like to check it out

Copy link
Contributor

@DorraJaouad DorraJaouad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM code-wise. However, the UI doesn't look much accessible cc @nextcloud/designers

image

image

@nickvergessen
Copy link
Member

@DorraJaouad @Antreesy please review

@hamza221 hamza221 marked this pull request as ready for review July 2, 2024 08:47
@hamza221 hamza221 requested a review from ShGKme July 2, 2024 08:47
Copy link
Contributor

@DorraJaouad DorraJaouad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, thanks!

@hamza221 hamza221 force-pushed the feat/ooo-replacement branch from 3a15e73 to aba12fc Compare July 2, 2024 11:51
@hamza221 hamza221 merged commit c21dd7e into main Jul 2, 2024
@hamza221 hamza221 deleted the feat/ooo-replacement branch July 2, 2024 14:28
@danxuliu danxuliu mentioned this pull request Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

6 participants