Fix user mentions with spaces #1254
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danxuliu
reviewed
Nov 9, 2018
Member
danxuliu
left a comment
danxuliu
left a comment
There was a problem hiding this comment.
Tested and works (after rebasing on master to relax the Content Security Policy), even with the contacts menu, nice :-)
This may need some adjustment depending on the changes in #1240 (as the user id is got from the avatar element), so I would like to wait until that one is finished to merge this one.
Signed-off-by: Joas Schilling <[email protected]>
nickvergessen
force-pushed
the
bugfix/1246/user-mentions-with-spaces
branch
from
e3695d6 to
ee5b106
Compare
Member
Author
|
Rebased, please review again @danxuliu |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1246