feat(mentions): prevent mention @all for non moderators

[sanskar-soni-9]

☑️ Resolves

• Fix Allow to prevent @all for non-moderators #9074

🛠️ API Checklist

🚧 Tasks

• Add tests
• Add docs

🏁 Checklist

• ⛑️ Tests (unit and/or integration) are included or not possible
• 📘 API documentation in docs/ has been updated or is not required
• 🔖 Capability is added or not needed

[nickvergessen]

Very excesive and complete pull request. Thanks a lot.
Had a quick look and most of it looks good, just some minor details.

Are you willing to also look into integration tests? Otherwise we can do that, no problem at all.

[sanskar-soni-9]

Thanks!

Are you willing to also look into integration tests? Otherwise we can do that, no problem at all.

Yeah I'm looking for complete pull request including tests and docs

[sanskar-soni-9]

I'm working on tests and docs, I will update it soon.

[sanskar-soni-9]

spreed/lib/Chat/ChatManager.php

Lines 975 to 977 in 4d15425

	if (str_starts_with('here', $search)) {
	return true;
	}

Hi @nickvergessen, is this still in use? with this we do receive mention object through mentions api call but it does not mark message as a mention and also doesn't notifies

[nickvergessen]

is this still in use? with this we do receive mention object through mentions api call but it does not mark message as a mention and also doesn't notifies

It only is on the suggestions, so when you type @here into the chat, it will suggest @all.
It does not do anything on send

[nickvergessen]

Frontend review and we are ready to go

[ShGKme]

Looks fine on the frontend side, just come nitpicks.

[sanskar-soni-9]

@nickvergessen sorry, I didn't updated local repo and directly force pushed, I recovered the changes but it will require your confirmation 😬

[nickvergessen]

I'll rebase to solve the conflict and regenerate openapi

[nickvergessen]

I also invited you to our org, so you can send your branches to our org, so we can easier collaborate and CI works

[sanskar-soni-9]

I also invited you to our org, so you can send your branches to our org, so we can easier collaborate and CI works

ok, really thanks, joined the org 🚀
And sorry again for the extra work, I forgot that my local branch was not updated