Skip to content

Fix silent call notifications in federated calls #12856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nickvergessen merged 4 commits into from
Aug 1, 2024
Merged

Fix silent call notifications in federated calls #12856

nickvergessen merged 4 commits into from
Aug 1, 2024

Conversation

@nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Jul 30, 2024 •
edited
Loading

☑️ Resolves

  • Explicitly start and end all calls with dedicated events and a single entry point instead of listening to ParticipantModifiedEvents
  • This allows to have the right and required information when the room was modified so we can transfer the silent-information to federated conversations and finally…
  • … fix silent calls

Fix #12844

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not possible
  • 📘 API documentation in docs/ has been updated or is not required
  • 🔖 Capability is added or not needed

@nickvergessen nickvergessen self-assigned this Jul 30, 2024
@nickvergessen nickvergessen marked this pull request as draft July 30, 2024 22:46
@nickvergessen nickvergessen mentioned this pull request Jul 30, 2024
Merged
6 tasks
@nickvergessen nickvergessen force-pushed the bugfix/12844/silent-calls branch 2 times, most recently from 8a0c994 to 616b26f Compare July 31, 2024 20:39
@nickvergessen nickvergessen requested review from Antreesy, SystemKeeper and danxuliu and removed request for Antreesy July 31, 2024 20:39
@nickvergessen nickvergessen added 3. to review bug feature: api 🛠️ OCS API for conversations, chats and participants feature: call 📹 Voice and video calls feature: federation 🌐 labels Jul 31, 2024
@nickvergessen nickvergessen added this to the 💙 Next Beta (30) milestone Jul 31, 2024
@nickvergessen nickvergessen marked this pull request as ready for review July 31, 2024 20:39
@nickvergessen nickvergessen force-pushed the bugfix/12844/silent-calls branch from 616b26f to 1e4fe0a Compare July 31, 2024 21:07
@nickvergessen nickvergessen changed the title Bugfix/12844/silent calls Fix silent call notifications in federated calls Jul 31, 2024
@nickvergessen nickvergessen mentioned this pull request Aug 1, 2024
Closed
42 tasks
Antreesy
Antreesy reviewed Aug 1, 2024
View reviewed changes
Copy link
Contributor

@Antreesy Antreesy left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Related? Can't start any call
image
Class "OCA\Talk\Events\BeforeCallStartedEvent" not found in file '/var/www/html/apps-extra/spreed/lib/Service/RoomService.php' line 896

@nickvergessen
Copy link
Member Author

nickvergessen commented Aug 1, 2024

Sounds related, but the file is there: https://github.com/nextcloud/spreed/pull/12856/files#diff-5fe63b0bd94ff82e9c8dde07bc8f48cd48864b8efd590bd6d1500987df3c754b And CI also passes?

@nickvergessen nickvergessen mentioned this pull request Aug 1, 2024
Merged
3 tasks
@nickvergessen nickvergessen merged commit 9154cb0 into main Aug 1, 2024
@nickvergessen nickvergessen deleted the bugfix/12844/silent-calls branch August 1, 2024 12:44
@nickvergessen nickvergessen mentioned this pull request Aug 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Antreesy Antreesy Antreesy left review comments

@SystemKeeper SystemKeeper SystemKeeper approved these changes

@danxuliu danxuliu Awaiting requested review from danxuliu

Assignees

@nickvergessen nickvergessen

Labels

3. to review bug feature: api 🛠️ OCS API for conversations, chats and participants feature: call 📹 Voice and video calls feature: federation 🌐

Projects

None yet

Milestone

v20.0.0-beta.2

Development

Successfully merging this pull request may close these issues.

Call notification missing for federated calls

4 participants

@nickvergessen @SystemKeeper @Antreesy