Skip to content

style: adjust line-height usage after change from px value to unitless #12870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Antreesy merged 1 commit into from
Aug 1, 2024
Merged

style: adjust line-height usage after change from px value to unitless #12870

Antreesy merged 1 commit into from
Aug 1, 2024

Conversation

@Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Aug 1, 2024 •
edited
Loading

☑️ Resolves

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🏚️ Before 🏡 After
image image

🏁 Checklist

  • 🌏 Tested with Chrome, Firefox and Safari or should not be risky to browser differences
  • 🖥️ Tested with Desktop client or should not be risky for it
  • 🖌️ Design was reviewed, approved or inspired by the design team

@Antreesy Antreesy added this to the 💙 Next Beta (30) milestone Aug 1, 2024
@Antreesy Antreesy requested review from DorraJaouad and ShGKme August 1, 2024 07:24
@Antreesy Antreesy self-assigned this Aug 1, 2024
ShGKme
ShGKme reviewed Aug 1, 2024
View reviewed changes
Copy link
Contributor

@ShGKme ShGKme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To not rely on unit kind

@ShGKme
Copy link
Contributor

ShGKme commented Aug 1, 2024

lh is not supported by Firefox 🙈

@ShGKme
Copy link
Contributor

ShGKme commented Aug 1, 2024

lh is not supported by Firefox 🙈

lh function is not supported, but lh unit is 🙈

Not a great support, but almost fine.

Let's go with lh then.

https://caniuse.com/mdn-css_types_length_lh

@Antreesy Antreesy force-pushed the fix/noid/adjust-line-height branch from 7c23c84 to 73b19a2 Compare August 1, 2024 09:08
@Antreesy Antreesy requested a review from ShGKme August 1, 2024 09:08
@Antreesy Antreesy merged commit 87e1d6c into main Aug 1, 2024
@Antreesy Antreesy deleted the fix/noid/adjust-line-height branch August 1, 2024 09:36
@ShGKme ShGKme mentioned this pull request Aug 1, 2024
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ShGKme ShGKme ShGKme approved these changes

@DorraJaouad DorraJaouad Awaiting requested review from DorraJaouad

Assignees

@Antreesy Antreesy

Labels

3. to review design feature: frontend 🖌️ "Web UI" client

Projects

None yet

Milestone

v20.0.0-beta.2

Development

Successfully merging this pull request may close these issues.

3 participants

@Antreesy @ShGKme