Skip to content

fix(activity): Add federated participants to activity and call summary #12874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nickvergessen merged 5 commits into from
Aug 1, 2024
Merged

fix(activity): Add federated participants to activity and call summary #12874

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1c673cd
fix(calls): Make starting a call an explicit event
nickvergessen Jul 31, 2024
e0bf7e2
fix(call): Add integration tests for end-for-everyone and silent calls
nickvergessen Jul 30, 2024
2a38a52
fix(calls): Explicitly end the call so we can notify the remote
nickvergessen Jul 31, 2024
1e4fe0a
fix(recording): Untangle the recording end from the activity generation
nickvergessen Jul 31, 2024
4ca3aed
fix(activity): Add federated participants to activity and call summary
nickvergessen Aug 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix(call): Add integration tests for end-for-everyone and silent calls 
Signed-off-by: Joas Schilling <[email protected]>
  • Loading branch information
@nickvergessen
nickvergessen committed Jul 31, 2024
commit e0bf7e2270f480b6287633171d7dfdeea9c06b36
63 changes: 63 additions & 0 deletions tests/integration/features/federation/call.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,6 +140,48 @@ Feature: federation/call
| federated_users | participant1@{$LOCAL_URL} | 0 |
| users | participant2 | 0 |

Scenario: Host ends call for everyone
Given user "participant1" creates room "room" (v4)
| roomType | 2 |
| roomName | room |
And user "participant1" adds federated_user "participant2@REMOTE" to room "room" with 200 (v4)
And using server "REMOTE"
And user "participant2" has the following invitations (v1)
| remoteServerUrl | remoteToken | state | inviterCloudId | inviterDisplayName |
| LOCAL | room | 0 | participant1@http://localhost:8080 | participant1-displayname |
And user "participant2" accepts invite to room "room" of server "LOCAL" with 200 (v1)
| id | name | type | remoteServer | remoteToken |
| LOCAL::room | room | 2 | LOCAL | room |
And using server "LOCAL"
And user "participant1" joins room "room" with 200 (v4)
And user "participant1" joins call "room" with 200 (v4)
| flags | 3 |
And using server "REMOTE"
And user "participant2" joins room "LOCAL::room" with 200 (v4)
And user "participant2" joins call "LOCAL::room" with 200 (v4)
| flags | 7 |
And user "participant2" sees the following attendees in room "LOCAL::room" with 200 (v4)
| actorType | actorId | inCall |
| federated_users | participant1@{$LOCAL_URL} | 3 |
| users | participant2 | 7 |
And using server "LOCAL"
And user "participant1" ends call "room" with 200 (v4)
Then user "participant1" is participant of room "room" (v4)
| callFlag |
| 0 |
And user "participant1" sees the following attendees in room "room" with 200 (v4)
| actorType | actorId | inCall |
| users | participant1 | 0 |
| federated_users | participant2@{$REMOTE_URL} | 0 |
And using server "REMOTE"
And user "participant2" is participant of room "LOCAL::room" (v4)
| callFlag |
| 0 |
And user "participant2" sees the following attendees in room "LOCAL::room" with 200 (v4)
| actorType | actorId | inCall |
| federated_users | participant1@{$LOCAL_URL} | 0 |
| users | participant2 | 0 |

Scenario: normal call notification for federated user
Given user "participant1" creates room "room" (v4)
| roomType | 2 |
Expand Down Expand Up @@ -207,6 +249,27 @@ Feature: federation/call
| app | object_type | object_id | subject |
| spreed | call | LOCAL::room | You missed a group call in room |

Scenario: silent call does not trigger call notification for federated users
Given user "participant1" creates room "room" (v4)
| roomType | 2 |
| roomName | room |
And user "participant1" adds federated_user "participant2@REMOTE" to room "room" with 200 (v4)
And using server "REMOTE"
And user "participant2" has the following invitations (v1)
| remoteServerUrl | remoteToken | state | inviterCloudId | inviterDisplayName |
| LOCAL | room | 0 | participant1@http://localhost:8080 | participant1-displayname |
And user "participant2" accepts invite to room "room" of server "LOCAL" with 200 (v1)
| id | name | type | remoteServer | remoteToken |
| LOCAL::room | room | 2 | LOCAL | room |
And user "participant2" joins room "LOCAL::room" with 200 (v4)
And using server "LOCAL"
And user "participant1" joins room "room" with 200 (v4)
When user "participant1" joins call "room" with 200 (v4)
| silent | true |
Then using server "REMOTE"
And user "participant2" has the following notifications
| app | object_type | object_id | subject |

Scenario: silent call by federated user does not trigger call notification
Given user "participant1" creates room "room" (v4)
| roomType | 2 |
Expand Down