fix: PublicShareSidebar for Nextcloud 31 #13628
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Antreesy
added
3. to review
bug
feature: frontend 🖌️
Antreesy
requested review from
DorraJaouad,
ShGKme,
danxuliu and
nickvergessen
Member
|
Failing sharing tests are unrelated and fixed by #13632 |
Antreesy
force-pushed
the
fix/13402/talk-sidebar-31
branch
from
2e58fa4 to
1d675ee
Compare
DorraJaouad
reviewed
Oct 27, 2024
In the frontend just use |
Antreesy
force-pushed
the
fix/13402/talk-sidebar-31
branch
2 times, most recently
from
c2a900b to
fad342b
Compare
Signed-off-by: Maksim Sukharev <[email protected]>
- replace NcButton with NcHeaderButton - move to script setup TS - adjust mountpoint to .header-end Signed-off-by: Maksim Sukharev <[email protected]>
- wrap mounting in function - adjust shareToken receiving to server API - adjust mountpoint to #content-vue Signed-off-by: Maksim Sukharev <[email protected]>
- remove publicshare.css as redundant - keep footer in place, adjust width if talk sidebar is open Signed-off-by: Maksim Sukharev <[email protected]>
Antreesy
force-pushed
the
fix/13402/talk-sidebar-31
branch
from
fad342b to
f538f9a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
🖌️ UI Checklist
🖼️ Screenshots / Screencasts
🏁 Checklist