Fix display name of reshare with one-to-one room not invited to #1426
Conversation
The display name of reshares with one-to-one rooms not invited to was always set to the display name of the last participant. Now it includes the name of both participants in the room instead. Note that this is not needed for deleted shares, as in that case only shares by the user, not reshares, need to be formatted. Signed-off-by: Daniel Calviño Sánchez <[email protected]>
danxuliu
added
3. to review
bug
feature: upload & shares & voice 📤🎙️
|
/backport to stable15 |
nickvergessen
left a comment
nickvergessen
left a comment
There was a problem hiding this comment.
Does what it says, however i'm not sure if we should leak the room/group/one2one names when the user is not part of it.
I thought the same, but the leaking is consistent with the behaviour of other shares; for example, when a share is reshared with a group, the name of the group can be seen too by the owner of the share even if she is not in that group. |
True, but there is a difference, you can share to that group yourself, while you can not share to rooms you are not a member off |
nickvergessen
deleted the
fix-display-name-of-reshare-with-one-to-one-room-not-invited-to
branch
|
backport to stable15 in #1495 |
The display name of reshares with one-to-one rooms not invited to was always set to the display name of the last participant. However, this happens since 4afa2d7; before that the first participant was always used. Now the name of both participants in the room is used instead, which also fixes the integration tests that were broken in 4afa2d7.