Show autocompletion as soon as "@" is typed #1482
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to show the autocompletion it was needed to type at least another character after "@", so only the mentions that matched that character were shown. Now the autocompletion is shown as soon as "@" is typed, which shows all the possible mentions in the room. Signed-off-by: Daniel Calviño Sánchez <[email protected]>
danxuliu
added
3. to review
feature: chat 💬
Ivansss
approved these changes
Jan 28, 2019
Contributor
|
As far as I can remember, this was intentional? |
Member
|
/backport to stable15 |
|
backport to stable15 in #1483 |
Member
|
Well, I geuss we blindly copied it from the comments app: I would suggest to also change it there, but yeah the new behaviour matches the expectations of users |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to show the autocompletion it was needed to type at least another character after @, so only the mentions that matched that character were shown. Now the autocompletion is shown as soon as @ is typed, which shows all the possible mentions in the room.