Skip to content

Conversation

@ShGKme
Copy link
Contributor

@ShGKme ShGKme commented Jun 25, 2025

☑️ Resolves

  • Fullscreen layout due to mounting inside #content instead of replacing it

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🏚️ Before 🏡 After
image image

🏁 Checklist

Copy link
Contributor

@DorraJaouad DorraJaouad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style

	// Fix fullscreen black bar on top
	&:fullscreen {
		padding-top: 0;

		:deep(.app-sidebar) {
			height: 100vh !important;
		}
	}

may not be used

@Antreesy Antreesy force-pushed the vue3 branch 2 times, most recently from 34b084c to e3d5161 Compare June 25, 2025 15:52
Base automatically changed from vue3 to main June 25, 2025 16:52
@ShGKme ShGKme force-pushed the chore/vue3--fullscreen branch from 04c931c to 8942dea Compare June 26, 2025 15:23
@ShGKme ShGKme force-pushed the chore/vue3--fullscreen branch from 8942dea to 4bb3d21 Compare June 27, 2025 14:10
@ShGKme
Copy link
Contributor Author

ShGKme commented Jun 27, 2025

The problem with an empty space (reproducible only with the default theme) fixed by applying styles to the :root

Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested

@ShGKme ShGKme force-pushed the chore/vue3--fullscreen branch from 4bb3d21 to 0933350 Compare June 27, 2025 14:20
@ShGKme ShGKme enabled auto-merge June 27, 2025 14:20
@ShGKme ShGKme merged commit 550a727 into main Jun 27, 2025
52 checks passed
@ShGKme ShGKme deleted the chore/vue3--fullscreen branch June 27, 2025 14:21
@Antreesy Antreesy added this to the v22.0.0-beta.1 milestone Sep 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants