Skip to content

Start changelog implementation #1616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nickvergessen merged 10 commits into from
Apr 2, 2019
Merged

Start changelog implementation #1616

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
79246e1
Start changelog implementation
nickvergessen Mar 14, 2019
1b9f739
Do not cleanup Changelog rooms
nickvergessen Mar 14, 2019
9503f42
Use a decent start message
nickvergessen Mar 14, 2019
1ed7363
Set read-only state for changelog rooms
nickvergessen Mar 19, 2019
f6aba70
Automatically close the sidebar when opening changelog conversation
nickvergessen Mar 20, 2019
f47fbb2
Exclude the changelog room from collections
nickvergessen Mar 29, 2019
39fe27a
Fix tests
nickvergessen Mar 29, 2019
8202432
Filter the changelog room from the list
nickvergessen Mar 29, 2019
d991e99
Allow changelog-convo to be a read-only convo
nickvergessen Apr 1, 2019
d7179be
Catch exception for unknown message
nickvergessen Apr 1, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Filter the changelog room from the list 
Signed-off-by: Joas Schilling <[email protected]>
  • Loading branch information
@nickvergessen
nickvergessen committed Apr 1, 2019
commit 820243278753db487ca58ed151c98ea3404bf7f8
10 changes: 9 additions & 1 deletion tests/integration/features/bootstrap/FeatureContext.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,12 +109,16 @@ public function userIsParticipantOfRooms($user, TableNode $formData = null) {
$this->assertStatusCode($this->response, 200);

$rooms = $this->getDataFromResponse($this->response);

$rooms = array_filter($rooms, function($room) {
return $room['type'] !== 4;
});

if ($formData === null) {
PHPUnit_Framework_Assert::assertEmpty($rooms);
return;
}


PHPUnit_Framework_Assert::assertCount(count($formData->getHash()), $rooms, 'Room count does not match');
PHPUnit_Framework_Assert::assertEquals($formData->getHash(), array_map(function($room, $expectedRoom) {
$participantNames = array_map(function($participant) {
Expand Down Expand Up @@ -166,6 +170,10 @@ public function userIsParticipantOfRoom($user, $isParticipant, $identifier) {

$rooms = $this->getDataFromResponse($this->response);

$rooms = array_filter($rooms, function($room) {
return $room['type'] !== 4;
});

if ($isParticipant) {
PHPUnit_Framework_Assert::assertNotEmpty($rooms);
}
Expand Down