chore(Parser): Remove no longer necessary sorting #16255
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove sorting workaround for mentions in comments. Implemented in getMentions() since 21.0.1. Signed-off-by: Josh <[email protected]>
joshtrichards
added
3. to review
feature: chat 💬
Member
|
The test also needs adjusting to reflect that. |
Member
Author
|
The current code may be hiding nextcloud/server#56162 so that may need to be dealt with first. |
Member
|
Then let's keep it for a while longer. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove sorting workaround for mentions in comments. Results are sorted within
getMentions()(since 21.0.1).