Skip to content

fix(messagesStore): process reactionsSelf for relayed reactions #16349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Antreesy merged 2 commits into from
Dec 15, 2025
Merged

fix(messagesStore): process reactionsSelf for relayed reactions #16349

Antreesy merged 2 commits into from
Dec 15, 2025

Conversation

@Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Nov 18, 2025

☑️ Resolves

  • Follow-up to feat: support chat relay in frontend #16299
  • Signaling backend and HPB service do not relay 'reactionsSelf' field, as it is unique to each attendee
  • It only modifies with attendee's actions, so client posess all the needed information

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🏁 Checklist

  • 🌏 Tested with different browsers / clients:
    • Chromium (Chrome / Edge / Opera / Brave)
    • Firefox
    • Safari
    • Talk Desktop
    • Integrations with Files sidebar and other apps
    • Not risky to browser differences / client
  • 🖌️ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

@Antreesy Antreesy added this to the 🍏 Next Major (33) milestone Nov 18, 2025
@Antreesy Antreesy requested a review from DorraJaouad November 18, 2025 11:29
@Antreesy Antreesy self-assigned this Nov 18, 2025
DorraJaouad
DorraJaouad reviewed Nov 18, 2025
View reviewed changes
@Antreesy Antreesy force-pushed the fix/16299/chat-relay-reactions branch from 98c9f64 to ae4d154 Compare November 27, 2025 12:34
Antreesy
Antreesy commented Dec 12, 2025
View reviewed changes
@Antreesy Antreesy force-pushed the fix/16299/chat-relay-reactions branch from ae4d154 to 3219085 Compare December 15, 2025 08:57
DorraJaouad
DorraJaouad approved these changes Dec 15, 2025
View reviewed changes
Copy link
Contributor

@DorraJaouad DorraJaouad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and tested

DorraJaouad
DorraJaouad reviewed Dec 15, 2025
View reviewed changes
@Antreesy
fix(messagesStore): mark messages to be processed from real-time
701cb83 
- this makes sure we do not update store with outdated information (from history fetching)

Signed-off-by: Maksim Sukharev <[email protected]>
@Antreesy
fix(messagesStore): process reactionsSelf for relayed reactions
0028110 
Signed-off-by: Maksim Sukharev <[email protected]>
@Antreesy Antreesy force-pushed the fix/16299/chat-relay-reactions branch from 3219085 to 0028110 Compare December 15, 2025 10:09
@Antreesy Antreesy enabled auto-merge December 15, 2025 10:11
@Antreesy
Copy link
Contributor Author

Antreesy commented Dec 15, 2025

/backport to stable32

@Antreesy Antreesy merged commit fa481ed into main Dec 15, 2025
55 checks passed
@Antreesy Antreesy deleted the fix/16299/chat-relay-reactions branch December 15, 2025 10:13
@backportbot backportbot bot mentioned this pull request Dec 15, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DorraJaouad DorraJaouad DorraJaouad approved these changes

Assignees

@Antreesy Antreesy

Labels

3. to review bug feature: frontend 🖌️ "Web UI" client feature: reactions 👍 feature: signaling 📶 Internal and external signaling backends

Projects

None yet

Milestone

v23.0.0-beta.1

Development

Successfully merging this pull request may close these issues.

3 participants

@Antreesy @DorraJaouad