Skip to content

fix: continue chat relay permanently #16359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
DorraJaouad merged 2 commits into from
Nov 24, 2025
Merged

fix: continue chat relay permanently #16359

DorraJaouad merged 2 commits into from
Nov 24, 2025

Conversation

@DorraJaouad
Copy link
Contributor

@DorraJaouad DorraJaouad commented Nov 19, 2025 •
edited
Loading

☑️ Resolves

image
experimentalChatRelay chatRelaySupported pollNewMessages?
false null now
false false now
false true now
true null timeout ⏲️
true false now
true true now

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🚧 Tasks

  • document reasoning in this PR

🏁 Checklist

  • 🌏 Tested with different browsers / clients:
    • Chromium (Chrome / Edge / Opera / Brave)
    • Firefox
    • Safari
    • Talk Desktop
    • Integrations with Files sidebar and other apps
    • Not risky to browser differences / client
  • 🖌️ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

@DorraJaouad DorraJaouad added this to the 🍏 Next Major (33) milestone Nov 19, 2025
@DorraJaouad DorraJaouad requested a review from Antreesy November 19, 2025 21:57
@DorraJaouad DorraJaouad self-assigned this Nov 19, 2025
@DorraJaouad DorraJaouad added enhancement feature: chat 💬 Chat and system messages labels Nov 19, 2025
@DorraJaouad DorraJaouad force-pushed the fix/noid/chat-relay-adjustment branch from b2f6cd8 to 9e817a1 Compare November 19, 2025 22:01
@DorraJaouad DorraJaouad changed the title fix: render enough messages when selecting context in chat blocks fix: continue chat relay permanently Nov 19, 2025
@DorraJaouad DorraJaouad force-pushed the fix/noid/chat-relay-adjustment branch from 9e817a1 to 49f3985 Compare November 20, 2025 09:24
Antreesy
Antreesy reviewed Nov 20, 2025
View reviewed changes
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to keep previous behaviour without experimental flag (no listeners, keep polling after context) and limit all new features to it

@DorraJaouad DorraJaouad force-pushed the fix/noid/chat-relay-adjustment branch 2 times, most recently from 246b43a to 61f3e96 Compare November 20, 2025 20:26
@DorraJaouad DorraJaouad requested a review from Antreesy November 21, 2025 12:35
Antreesy
Antreesy reviewed Nov 21, 2025
View reviewed changes
Antreesy
Antreesy approved these changes Nov 24, 2025
View reviewed changes
@DorraJaouad DorraJaouad force-pushed the fix/noid/chat-relay-adjustment branch from 358b294 to 01a0112 Compare November 24, 2025 13:13
@Antreesy
Copy link
Contributor

Antreesy commented Nov 24, 2025

/backport to stable32

@Antreesy Antreesy mentioned this pull request Nov 24, 2025
Merged
14 tasks
@DorraJaouad DorraJaouad merged commit fd72c5a into main Nov 24, 2025
56 checks passed
@DorraJaouad DorraJaouad deleted the fix/noid/chat-relay-adjustment branch November 24, 2025 14:14
@backportbot backportbot bot mentioned this pull request Nov 24, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Antreesy Antreesy Antreesy approved these changes

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

Assignees

@DorraJaouad DorraJaouad

Labels

enhancement feature: chat 💬 Chat and system messages

Projects

None yet

Milestone

v23.0.0-beta.1

Development

Successfully merging this pull request may close these issues.

3 participants

@DorraJaouad @Antreesy