-
Notifications
You must be signed in to change notification settings - Fork 509
feat: implement UI for scheduled messages ⏲️ #16509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
1d0b3a4 to
8a09f13
Compare
8a09f13 to
aadada5
Compare
aadada5 to
ba4f63c
Compare
DorraJaouad
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have not checked the last two commits yet, will come back
src/components/MessagesList/MessagesGroup/Message/MessagePart/ReactionsWrapper.spec.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, looking great! Overall small changes:
- It seems like the "Message will be sent..." info box is quite far from the input field. Could we move it maybe 1* or 2*(--default-grid-baseline) away from the input field?
- In the 3 dot menu for a scheduled message, delete should always be the last item. Could we move "Send message now" to below "Reschedule" (or even inside the reschedule submenu)
- Wording:
- "Please choose a date" --> "Choose a time"
- "Send on custom time" --> "Send at custom time" (I think)
- "Send message now" --> "Send now"
- "Edit message" --> "Edit" (even in the normal message action menu)
- Icons:
- use the outlined version of the send and send later icons
Similar to the initial version of threads I suspect it is difficult to see clearly when we have switch to the scheduled messages view, so some changes to improve that:
- Remove the start call, meetings, etc buttons from the convo header inside
- can we change the conversation title to
Scheduled messagesand sublinein [convo name](if it is a direct messageto [person name]) - Nice-to-have: in the list of scheduled messages could we add "Send on" in the date separators, so
Send on December 18th
From issue:
- if there are scheduled messages, the button is shown next to the input field. It disappears when the input field is focused
- If there are no scheduled messages and user is scheduling one, once they click send (or press enter) the clock icon button will appear as confirmation that the message is scheduled.
- nice-to-have: the appearance of this button is animated (input field shrinks and button appears)
- If there are scheduled messages and user is scheduling one, once they click send, the existing clock icon button should have a little animation to confirm that the message was scheduled, something like this:
src/components/MessagesList/MessagesGroup/Message/MessageButtonsBar/ScheduledMessageActions.vue
Outdated
Show resolved
Hide resolved
src/components/MessagesList/MessagesGroup/Message/MessageButtonsBar/ScheduledMessageActions.vue
Outdated
Show resolved
Hide resolved
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
7347328 to
2d37159
Compare
DorraJaouad
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GTG
nimishavijay
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great! :)
Signed-off-by: Maksim Sukharev <[email protected]>
Signed-off-by: Maksim Sukharev <[email protected]>
Signed-off-by: Maksim Sukharev <[email protected]>
Signed-off-by: Maksim Sukharev <[email protected]>
Signed-off-by: Maksim Sukharev <[email protected]>
Signed-off-by: Maksim Sukharev <[email protected]>
06a12b2 to
988a7a8
Compare
☑️ Resolves
🖌️ UI Checklist
🖼️ Screenshots / Screencasts
POST
GET
2025-12-17_15h38_15.mp4
🚧 Tasks
🏁 Checklist