[stable15] Fix duplicated candidate mentions in file rooms #1693
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
backportbot-nextcloud
bot
added
bug
feature: chat 💬
backportbot-nextcloud
bot
requested review from
Ivansss,
danxuliu and
nickvergessen
danxuliu
requested changes
Apr 9, 2019
Member
danxuliu
left a comment
danxuliu
left a comment
There was a problem hiding this comment.
The backported tests fail because @all was not implemented in Talk 5; I will fix those tests.
Signed-off-by: Daniel Calviño Sánchez <[email protected]>
In regular rooms only the current participants are candidates in mentions, but in file rooms the candidates are all the users with access to the file, even if they are not currently participants of the room. However, as the users with access to the file are a superset of the current participants those participants were returned twice. Therefore, now candidates for mentions in file rooms are got only from the users with access to the file instead of in addition to the current participants. Signed-off-by: Daniel Calviño Sánchez <[email protected]>
danxuliu
force-pushed
the
backport/1682/stable15
branch
from
58b512b to
c68ab9a
Compare
danxuliu
approved these changes
Apr 9, 2019
Member
danxuliu
left a comment
danxuliu
left a comment
There was a problem hiding this comment.
Backported tests fixed; failing tests are not related to the backported ones.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of #1682