Skip to content

Conversation

@jancborchardt
Copy link
Member

Markdown like bolding and linking does not work in the app description in the management, makes the entry look strange.

Also I cut the part »And in the works for the [coming versions]« because that makes the entry wayyy too long.

@nickvergessen @Ivansss please review.

@nickvergessen
Copy link
Member

This is for the app store and it does support markdown.

The app management page promised to also support it:
nextcloud/server#1594

And I think it's more important that it looks nice on the app store then in the app management. Also tons of other apps also use markdown already, so let's just increase the pressure on nextcloud to fix the parsing to also support markdown in the app management.

@jancborchardt
Copy link
Member Author

let's just increase the pressure on nextcloud

This is not how it works. ;) We are Nextcloud. And we can’t have the description of an advertised app less nice than necessary in the apps management. This is a good middle ground.

Please review @LukasReschke @MorrisJobke

@MorrisJobke
Copy link
Member

I would say that we provide a readable (this PR) for stable versions and go for the server PR with master.

@jancborchardt
Copy link
Member Author

We don’t have any stable branch right now, how do we proceed then? How about we merge this now, and I’m happy to change it back as soon as the server capability is there?

@nickvergessen
Copy link
Member

Has been merged in 12 and will be backported for 11.0.2

So I'm closing this.

@jancborchardt
Copy link
Member Author

Yup, nice! 👍

@jancborchardt jancborchardt deleted the app-description branch January 17, 2017 12:13
@MorrisJobke
Copy link
Member

Looks really nice now:

bildschirmfoto 2017-01-17 um 09 26 44

👍

marcoambrosini pushed a commit that referenced this pull request Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants