Skip to content

Bugfix/1938/multi line input overlaps latest messages #1950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
marcoambrosini wants to merge 5 commits into from
Closed

Bugfix/1938/multi line input overlaps latest messages #1950

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
fd5851a
created a new method for scrolling to last visible element based on t…
marcoambrosini Jul 3, 2019
ce2d492
added event emitter and handler for form resize
marcoambrosini Jul 3, 2019
8960409
changed let declaration to var
marcoambrosini Jul 3, 2019
91995a6
fixed issue with undefined initialFormHeight
marcoambrosini Jul 3, 2019
e62c2c2
removed unnecessary methods from scrollToLastVisibleElement()
marcoambrosini Jul 3, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
changed let declaration to var 
Signed-off-by: Marco Ambrosini <[email protected]>
  • Loading branch information
@marcoambrosini
marcoambrosini committed Jul 3, 2019
commit 89604097908c233f735d739bfb97a8fce51caa0d
2 changes: 1 addition & 1 deletion js/views/chatview.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@
},

handleFormResize : function (initialFormHeight) {
let formHeight = document.getElementsByClassName('newCommentForm')[0].clientHeight;
var formHeight = document.getElementsByClassName('newCommentForm')[0].clientHeight;
console.log('Initial form heigth: ' + initialFormHeight + ', actual form height: ' + formHeight)
if (initialFormHeight < formHeight) {
this._virtualList.scrollToLastVisibleElement();
Expand Down