Skip to content

Support file calls in groupfolders #2102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nickvergessen merged 2 commits into from
Aug 28, 2019
Merged

Support file calls in groupfolders #2102

nickvergessen merged 2 commits into from
Aug 28, 2019

Conversation

@nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Aug 22, 2019 •
edited
Loading

Fix #2088

@nickvergessen nickvergessen added 2. developing bug help wanted feature: talk-sidebar ⬅️ Sidebar integration of Talk into other apps like sharing and documents labels Aug 22, 2019
@nickvergessen nickvergessen added this to the 💚 Next Major milestone Aug 22, 2019
@nickvergessen nickvergessen requested a review from danxuliu August 22, 2019 14:40
@nickvergessen
Copy link
Member Author

nickvergessen commented Aug 23, 2019

Rebasing on #2084

@nickvergessen nickvergessen force-pushed the bugfix/2088/support-file-calls-in-groupfolders branch from 7d9caf1 to fd6cc4a Compare August 23, 2019 11:33
@nickvergessen
Copy link
Member Author

nickvergessen commented Aug 23, 2019

Ready to review

danxuliu
danxuliu requested changes Aug 27, 2019
View reviewed changes
Copy link
Member

@danxuliu danxuliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is not happy (Error: Call to a member function getStorage() on null at /drone/server/apps/spreed/lib/Files/Util.php#195)

Besides that, would it be possible to add integration tests for group folders? Can the OCS endpoints in the server be used or does it require the groupfolders app?

@nickvergessen
Copy link
Member Author

nickvergessen commented Aug 27, 2019

The app is required so the class of the storage exists.... But I will at least try a unit test

@nickvergessen
Copy link
Member Author

nickvergessen commented Aug 28, 2019

Done

danxuliu
danxuliu requested changes Aug 28, 2019
View reviewed changes
Copy link
Member

@danxuliu danxuliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Candidate mentions are not shown for users with access to the group folder. Also, mentioning a user with access to the group folder that is not yet in the room does not add the user (it does with users with access to a share but that have not joined yet).

@nickvergessen
Copy link
Member Author

nickvergessen commented Aug 28, 2019

That will have to wait for now, as the GroupFolders app does not have a public interface to check for that, at least I'm not seeing any.

I suggest to continue for now without the mention things, as it's still better to be able to use the file rooms in a groupfolder enviroment.

@nickvergessen nickvergessen merged commit b2e30c4 into master Aug 28, 2019
@delete-merged-branch delete-merged-branch bot deleted the bugfix/2088/support-file-calls-in-groupfolders branch August 28, 2019 12:20
@danxuliu danxuliu mentioned this pull request Aug 30, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@danxuliu danxuliu danxuliu approved these changes

Assignees

No one assigned

Labels

3. to review bug feature: talk-sidebar ⬅️ Sidebar integration of Talk into other apps like sharing and documents help wanted

Projects

None yet

Milestone

7.0.0-beta1

Development

Successfully merging this pull request may close these issues.

Talk doesn't detect group folders

3 participants

@nickvergessen @danxuliu