Skip to content

Add support for Talk Sidebar in public share pages #2107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nickvergessen merged 21 commits into from
Sep 27, 2019
Merged

Add support for Talk Sidebar in public share pages #2107

Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
edc54ea
Add support for public shares to file rooms
danxuliu Jul 18, 2018
8de6a11
Add integration tests for files shared by link
danxuliu Aug 14, 2019
3d89459
Add integration tests for self-joined users in files shared by link
danxuliu Aug 14, 2019
b10313c
Add self-joined users and guests to the candidate mentions in file rooms
danxuliu Aug 14, 2019
6bb86a4
Add integration tests for mentions in a file shared by link
danxuliu Aug 14, 2019
ca62f9d
Fix avatar container height during calls
danxuliu Sep 16, 2019
1ba0f4f
Add support for Talk sidebar in public share pages
danxuliu Aug 15, 2019
255ac5d
Add basic acceptance tests for the Talk sidebar in the public share page
danxuliu Aug 16, 2019
83b5469
Add acceptance tests for Talk sidebar in public share page to Drone
danxuliu Aug 16, 2019
aaa8b84
Add acceptance tests for registered users in the public share page
danxuliu Aug 16, 2019
cd17e48
Add acceptance tests for mentioning users in the Files app
danxuliu Aug 16, 2019
c03ab40
Add acceptance tests for mentions in the public share page
danxuliu Aug 16, 2019
7f731bd
Add acceptance tests for chats in a file shared by link
danxuliu Aug 16, 2019
b4a2907
Add acceptance tests for chats in a file shared by link with a password
danxuliu Aug 16, 2019
41a1556
Correctly check if the share has a password and if it was entered cor…
nickvergessen Aug 16, 2019
b77d4b2
Add integration tests for getting the room for link share with password
danxuliu Aug 17, 2019
7fdcb46
Do not add system message for self joined users to file rooms
danxuliu Aug 19, 2019
6f8ac51
Add integration tests for the "user_added" system message
danxuliu Aug 19, 2019
129a3c1
Add wrapper around "OC.getCurrentUser()" to be able to override the user
danxuliu Sep 25, 2019
c1e6687
Override the current user when getting the room for a public share page
danxuliu Sep 25, 2019
891a73f
Fix guest avatars in public share page
danxuliu Sep 25, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add acceptance tests for mentioning users in the Files app 
Signed-off-by: Daniel Calviño Sánchez <[email protected]>
  • Loading branch information
@danxuliu
danxuliu committed Sep 26, 2019
commit cd17e48f0812e3ae41650aad1282cd55e1d7c630
45 changes: 45 additions & 0 deletions tests/acceptance/features/app-files.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,51 @@ Feature: app-files



Scenario: mention a user that has not joined yet but has access to a file room
Given I act as John
And I am logged in as the admin
And I share "welcome.txt" with "user0"
And I see that the file is shared with "user0"
And I open the Chat tab in the details view of the Files app
And I see that the chat is shown in the Chat tab
And I act as Jane
And I am logged in
And I have opened the Talk app
# Wait until the "Talk updates" conversation is shown to ensure that the
# list is loaded before checking that there is no "welcome.txt" conversation
And I see that the "Talk updates ✅" conversation is shown in the list
And I see that the "welcome.txt" conversation is not shown in the list
When I act as John
And I type a new chat message with the text "Hello @"
And I choose the candidate mention for "user0"
And I send the current chat message
Then I see that the message 1 was sent by "admin" with the text "Hello user0"
And I see that the message 1 contains a formatted mention of "user0"
And I act as Jane
And I see that the "welcome.txt" conversation is shown in the list

Scenario: mention all users when a user has not joined yet the file room
Given I act as John
And I am logged in as the admin
And I share "welcome.txt" with "user0"
And I see that the file is shared with "user0"
And I open the Chat tab in the details view of the Files app
And I see that the chat is shown in the Chat tab
When I type a new chat message with the text "Hello @"
And I choose the candidate mention for "welcome.txt"
And I send the current chat message
Then I see that the message 1 was sent by "admin" with the text "Hello welcome.txt"
And I see that the message 1 contains a formatted mention of all participants of "welcome.txt"
And I act as Jane
And I am logged in
And I have opened the Talk app
# Wait until the "Talk updates" conversation is shown to ensure that the
# list is loaded before checking that there is no "welcome.txt" conversation
And I see that the "Talk updates ✅" conversation is shown in the list
And I see that the "welcome.txt" conversation is not shown in the list



Scenario: chat in a shared file
Given I act as John
And I am logged in as the admin
Expand Down