Skip to content

Provide feedback to the user when some operations are in progress #2117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nickvergessen merged 7 commits into from
Aug 28, 2019
Merged

Provide feedback to the user when some operations are in progress #2117

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
0c37737
Use "prop()" instead of "attr()" to get properties
danxuliu Aug 20, 2019
f56122a
Wait for the server response to set the room as public or private
danxuliu Aug 20, 2019
5d6ed51
Provide feedback while waiting for the server to set the password
danxuliu Aug 21, 2019
bb1ad01
Do not mark the password field as required
danxuliu Aug 21, 2019
4af0898
Fix markup
danxuliu Aug 21, 2019
7948939
Simplify CSS rules for confirm icon in editable text label
danxuliu Aug 21, 2019
584b30d
Wait for the server response to rename the room
danxuliu Aug 21, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Do not mark the password field as required 
An empty password can be sent to remove the current password of the
room, which does not match with the "required" semantics. Moreover, the
CSS styles show a red border in invalid input fields, so the red border
was shown too when removing the password despite being a valid
operation.

Signed-off-by: Daniel Calviño Sánchez <[email protected]>
  • Loading branch information
@danxuliu
danxuliu committed Aug 27, 2019
commit bb1ad01cec4da74aa5838b92b73926ca861178b6
2 changes: 1 addition & 1 deletion js/views/templates.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ templates['callinfoview'] = template({"1":function(container,depth0,helpers,part
+ ((stack1 = helpers["if"].call(alias1,(depth0 != null ? depth0.hasPassword : depth0),{"name":"if","hash":{},"fn":container.program(8, data, 0),"inverse":container.program(10, data, 0),"data":data})) != null ? stack1 : "")
+ "\"></span>\n <div class=\"popovermenu password-menu menu-right\">\n <ul>\n <li>\n <span class=\"menuitem "
+ ((stack1 = helpers["if"].call(alias1,(depth0 != null ? depth0.hasPassword : depth0),{"name":"if","hash":{},"fn":container.program(8, data, 0),"inverse":container.program(10, data, 0),"data":data})) != null ? stack1 : "")
+ " password-option\">\n <form class=\"password-form\">\n <input class=\"password-input\" required maxlength=\"200\" type=\"password\"\n placeholder=\""
+ " password-option\">\n <form class=\"password-form\">\n <input class=\"password-input\" maxlength=\"200\" type=\"password\"\n placeholder=\""
+ container.escapeExpression(((helper = (helper = helpers.passwordInputPlaceholder || (depth0 != null ? depth0.passwordInputPlaceholder : depth0)) != null ? helper : helpers.helperMissing),(typeof helper === "function" ? helper.call(alias1,{"name":"passwordInputPlaceholder","hash":{},"data":data}) : helper)))
+ "\">\n <input type=\"submit\" value=\"\" autocomplete=\"new-password\" class=\"icon icon-confirm password-confirm\"></input>\n <span class=\"icon icon-loading-small password-loading hidden\"/>\n </form>\n </span>\n </li>\n </ul>\n </div>\n </div>\n";
},"8":function(container,depth0,helpers,partials,data) {
Expand Down
2 changes: 1 addition & 1 deletion js/views/templates/callinfoview.handlebars
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
<li>
<span class="menuitem {{#if hasPassword}}icon-password{{else}}icon-no-password{{/if}} password-option">
<form class="password-form">
<input class="password-input" required maxlength="200" type="password"
<input class="password-input" maxlength="200" type="password"
placeholder="{{passwordInputPlaceholder}}">
<input type="submit" value="" autocomplete="new-password" class="icon icon-confirm password-confirm"></input>
<span class="icon icon-loading-small password-loading hidden"/>
Expand Down