Skip to content

Fixes for keyboard navigation #2122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nickvergessen merged 12 commits into from
Aug 28, 2019
Merged

Fixes for keyboard navigation #2122

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
89921bc
Do not select again an already selected tab
danxuliu Aug 23, 2019
819b5a0
Fix keyboard navigation in tab headers
danxuliu Aug 23, 2019
e45e375
Fix select2 containers not highlighted when focused
danxuliu Aug 23, 2019
671feab
Fix "copy link" button not focusable
danxuliu Aug 25, 2019
04d2a47
Fix edit button in EditableTextLabel not focusable
danxuliu Aug 25, 2019
0f5392a
Fix sidebar trigger not focusable
danxuliu Aug 25, 2019
472d1a0
Remove reference to inexistent event handler
danxuliu Aug 25, 2019
1bf31f5
Fix password button not focusable
danxuliu Aug 25, 2019
5e79ab9
Remove unused CSS rule
danxuliu Aug 25, 2019
5b89513
Fix participant items being focusable
danxuliu Aug 25, 2019
9692378
Fix pointer cursor not shown on participants with a contacts menu
danxuliu Aug 25, 2019
bf87c25
Fix avatars of participants with contacts menu not focusable
danxuliu Aug 25, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove unused CSS rule 
The first link child of items in the participants list is the
participant information, which includes the avatar, name... However,
there is no direct "img" child of that element (the avatar image is a
child of the avatar element), so the rule has no effect.

Signed-off-by: Daniel Calviño Sánchez <[email protected]>
  • Loading branch information
@danxuliu
danxuliu committed Aug 28, 2019
commit 5e79ab9aa8966f5e2605cdf8c00fe5c855cbbebf
1 change: 0 additions & 1 deletion css/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,7 +206,6 @@ input[type="password"] {
top: 6px;
}

.participantWithList > li > a:first-child > img,
#app-navigation li > a:first-child img {
width: 32px !important;
height: 32px !important;
Expand Down