[stable16] Provide feedback to the user when some operations are in progress #2131
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Calviño Sánchez <[email protected]>
backportbot-nextcloud
bot
requested review from
Ivansss,
danxuliu and
nickvergessen
nickvergessen
approved these changes
Aug 29, 2019
danxuliu
requested changes
Aug 29, 2019
Member
danxuliu
left a comment
danxuliu
left a comment
There was a problem hiding this comment.
There is a minor issue with the loading spinner position on checkboxes; I will take care of that.
Until now the model was updated as soon as the checkbox was modified, which triggered a change event that in turn caused the UI to be updated. However, if the room could not be successfully set as public or private nothing was done and the model as well as the UI were kept with the wrong state (at least, until the model is fetched again). To prevent this now the model waits for a successful server response to update the attributes; in case of failure only the checkbox needs to be restored, as it is the only UI element that changed due to the direct interaction of the user (in case of success the whole view will be rendered again due to the room type change, so no need to do anything explicitly in that case). As the model is not changed until the successful server response is received now the checkbox is replaced by a working icon while waiting for the answer. In a similar way the checkbox is also disabled to prevent further requests while the previous one is ongoing. Signed-off-by: Daniel Calviño Sánchez <[email protected]>
Due to its special nature the password is not stored in an attribute of the model. Nevertheless, a "changed:password" (always with an empty value) was triggered as soon as the password was submited. However, as there is no password attribute that event is not taken into account anywhere and the UI was not updated until the server response was received (with further updates once the rooms are fetched again). To provide feedback to the user that the password is being set now the confirm button is replaced by a working icon while waiting for the answer. In a similar way the input is also disabled to prevent further requests while the previous one is ongoing. Note that due to the aforementioned behaviour it is not really necessary to wait for the server response to update the model with the new password (as it will not be updated anyway), but it is done for consistency with other requests. Signed-off-by: Daniel Calviño Sánchez <[email protected]>
An empty password can be sent to remove the current password of the room, which does not match with the "required" semantics. Moreover, the CSS styles show a red border in invalid input fields, so the red border was shown too when removing the password despite being a valid operation. Signed-off-by: Daniel Calviño Sánchez <[email protected]>
Signed-off-by: Daniel Calviño Sánchez <[email protected]>
The input wrapper only contains the text input and the confirm button; as there will not be more than one confirm button there is no need to set its rules based on the text input. Signed-off-by: Daniel Calviño Sánchez <[email protected]>
Until now the EditableTextLabel was not (visibly) updated until the server response was received, even if the model was updated as soon as the new value was submitted (although this updated the hidden label, which was shown again once the response was received). To provide feedback to the user that the value is being set now the confirm button is replaced by a working icon while waiting for the response. In a similar way the input is also disabled to prevent further requests while the previous one is ongoing. Besides that, renaming the room now waits for the server response before updating the model. This ensures that, in case of error, the label will still show the old value instead of the new one. An error message is now also shown to the user in that case. Signed-off-by: Daniel Calviño Sánchez <[email protected]>
danxuliu
force-pushed
the
backport/2117/stable16
branch
from
d54afc0 to
06fa1c3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of #2117