Add acceptance tests for lobby to Drone #2134
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Calviño Sánchez <[email protected]>
Ivansss
approved these changes
Aug 29, 2019
Member
|
Should have a test which checks for such cases? 🤔 |
Member
Author
While it would be nice I guess that it would depend on the effort needed to implement the check; I am not sure if it will be worth it based on how often new feature files are added to the acceptance tests and the impact of not adding them at the proper time, but if you want of course feel free to do it. |
delete-merged-branch
bot
deleted the
add-acceptance-tests-for-lobby-to-drone
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I forgot this in #1926 🤦♂️