Add self-joined users and guests to the candidate mentions in file rooms

File rooms were available only to users with direct access to the file,
so those were the users that could be mentioned. Now file rooms are
publicly available if the file is shared by link, so the mentions now
include all the users with direct access to the file like before plus
all the self-joined users and guests currently in the room.

Note, however, that self-joined users and guests can still not mention
users with direct access to the file that have not joined the room yet,
but only those that joined the room already (plus any participant that
is currently in the room).

Signed-off-by: Daniel Calviño Sánchez <[email protected]>

lib/Chat/AutoComplete/SearchPlugin.php

@@ -84,8 +84,6 @@ public function search($search, $limit, $offset, ISearchResult $searchResult) {
 			if (!empty($usersWithFileAccess)) {
 				$this->searchUsers($search, $usersWithFileAccess, $searchResult);
 			}
-
-			return false;
 		}
 
 		$userIds = $guestSessionHashes = [];
@@ -113,13 +111,19 @@ public function search($search, $limit, $offset, ISearchResult $searchResult) {
 	protected function searchUsers(string $search, array $userIds, ISearchResult $searchResult): void {
 		$search = strtolower($search);
 
+		$type = new SearchResultType('users');
+
 		$matches = $exactMatches = [];
 		foreach ($userIds as $userId) {
 			if ($this->userId !== '' && $this->userId === $userId) {
 				// Do not suggest the current user
 				continue;
 			}
 
+			if ($searchResult->hasResult($type, $userId)) {
+				continue;
+			}
+
 			if ($search === '') {
 				$matches[] = $this->createResult('user', $userId, '');
 				continue;
@@ -151,7 +155,6 @@ protected function searchUsers(string $search, array $userIds, ISearchResult $se
 			}
 		}
 
-		$type = new SearchResultType('users');
 		$searchResult->addResultSet($type, $matches, $exactMatches);
 	}