Do not load Talk sidebar in public share page of folder shares #2339
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danxuliu
added
3. to review
backport-request
bug
feature: talk-sidebar ⬅️
Member
Author
|
Backport to stable17 in #2340 |
nickvergessen
approved these changes
Oct 21, 2019
Member
|
The Talk sidebar is only shown for file shares, so there is no need to load it for folder shares. Moreover, this also prevents some of the hacks used to show the Talk sidebar to mess with the layout used for folders. Signed-off-by: Daniel Calviño Sánchez <[email protected]>
danxuliu
force-pushed
the
do-not-load-talk-sidebar-in-public-share-page-of-folder-shares
branch
from
dc3abae to
645c721
Compare
Member
Author
|
Rebased due to conflicts with #2283. |
delete-merged-branch
bot
deleted the
do-not-load-talk-sidebar-in-public-share-page-of-folder-shares
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires nextcloud/server#17575
The Talk sidebar is only shown for file shares, so there is no need to load it for folder shares. Moreover, this also prevents some of the hacks used to show the Talk sidebar to mess with the layout used for folders.