[stable17] Adjust acceptance tests to changes in Files app and public share page #2457
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now the conversation needs to be explicitly joined by pressing a button in the Files app and the public share page. Signed-off-by: Daniel Calviño Sánchez <[email protected]>
danxuliu
force-pushed
the
adjust-acceptance-tests-to-changes-in-files-app-and-public-share-pages
branch
from
e10daf6 to
2f1271b
Compare
Member
Random failure? |
nickvergessen
approved these changes
Nov 13, 2019
Member
Author
|
Yes, it is caused by trying to click the join button when it was made visible but not moved yet into the viewport. It can be handled in a generic way in the acceptance test framework in server; until then the acceptance tests that click the join button in the public share page may fail sometimes, but it should not happen too often given that the animation only lasts 100ms. |
danxuliu
deleted the
adjust-acceptance-tests-to-changes-in-files-app-and-public-share-pages
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #2347 and #2423
Now the conversation needs to be explicitly joined by pressing a button in the Files app and the public share page.