Skip to content

Receive shares in Talk/ folder #2876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nickvergessen merged 5 commits into from
Mar 6, 2020
Merged

Receive shares in Talk/ folder #2876

nickvergessen merged 5 commits into from
Mar 6, 2020

Conversation

@nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Jan 31, 2020 •
edited
Loading

@nickvergessen nickvergessen added this to the 💚 Next Major (19) milestone Jan 31, 2020
@nickvergessen nickvergessen mentioned this pull request Feb 6, 2020
Merged
@nickvergessen nickvergessen mentioned this pull request Feb 19, 2020
Merged
2 tasks
@nickvergessen nickvergessen force-pushed the techdebt/1811/receive-shares-in-talk-folder branch from 51ce150 to 4278f35 Compare February 21, 2020 13:15
@nickvergessen nickvergessen requested review from danxuliu and marcoambrosini and removed request for danxuliu February 28, 2020 12:41
@nickvergessen nickvergessen force-pushed the techdebt/1811/receive-shares-in-talk-folder branch from 4278f35 to 7171732 Compare February 28, 2020 12:43
@nickvergessen nickvergessen marked this pull request as ready for review February 28, 2020 12:43
marcoambrosini
marcoambrosini approved these changes Mar 3, 2020
View reviewed changes
Copy link
Member

@marcoambrosini marcoambrosini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works 👍

@nickvergessen
Copy link
Member Author

nickvergessen commented Mar 3, 2020

One time I would like to see the sharing integration tests pass here

@nickvergessen nickvergessen force-pushed the techdebt/1811/receive-shares-in-talk-folder branch 4 times, most recently from 230cc0d to 819fd21 Compare March 4, 2020 16:21
@nickvergessen
Copy link
Member Author

nickvergessen commented Mar 5, 2020

I don't know whats wrong with those failing two tests.
They work fine isolated and running the full file and running the full folder,
but they fail 100% of the time on drone.

@nickvergessen nickvergessen force-pushed the techdebt/1811/receive-shares-in-talk-folder branch from 819fd21 to 20c25e8 Compare March 6, 2020 10:11
@nickvergessen nickvergessen merged commit a00a12d into master Mar 6, 2020
@nickvergessen nickvergessen deleted the techdebt/1811/receive-shares-in-talk-folder branch March 6, 2020 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marcoambrosini marcoambrosini marcoambrosini approved these changes

Assignees

No one assigned

Labels

3. to review enhancement feature: upload & shares & voice 📤🎙️ Sharing files into a chat and audio recordings technical debt

Projects

None yet

Milestone

v9.0.0-beta1

Development

Successfully merging this pull request may close these issues.

Shared files are saved in the root folder for new users Improve the way we handle shared files

3 participants

@nickvergessen @marcoambrosini