Add hint to settings #305
Merged
Add hint to settings #305
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
templates/settings-admin.php
Outdated
| <div id="spreed" class="section"> | ||
| <form id="spreed_settings_form" class="spreed_settings"> | ||
| <h2 class="app-name">Spreed video calls</h2> | ||
| <p class="settings-hint"><?php p($l->t('The STUN and TURN servers should be configured to ensure best call quality in any scenario.')); ?></p> |
Member
There was a problem hiding this comment.
turn is not about quality, but whether you can connect at all.
Member
There was a problem hiding this comment.
Same for stun, both are about connectivity.
Member
Author
There was a problem hiding this comment.
Fixed, is this better? :)
Codecov Report
@@ Coverage Diff @@
## master #305 +/- ##
=========================================
Coverage 15.46% 15.46%
Complexity 274 274
=========================================
Files 18 18
Lines 1293 1293
=========================================
Hits 200 200
Misses 1093 1093Continue to review full report at Codecov.
|
Signed-off-by: Jan-Christoph Borchardt <[email protected]>
jancborchardt
force-pushed
the
settings-help
branch
from
998a895 to
d731287
Compare
marcoambrosini
pushed a commit
that referenced
this pull request
Oct 9, 2019
…k-cli-3.3.0 Bump webpack-cli from 3.2.3 to 3.3.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding more hints to settings, ref nextcloud/server#4478 nextcloud/server#4540
Please review @karlitschek @nextcloud/spreed