Skip to content

Conversation

@nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Mar 23, 2020

Signed-off-by: Joas Schilling <[email protected]>
@nickvergessen nickvergessen force-pushed the techdebt/noid/allow-some-apps-to-have-root-urls branch from 502756a to 1cdd856 Compare April 22, 2020 09:44
@nickvergessen nickvergessen requested a review from danxuliu April 22, 2020 10:08
@nickvergessen
Copy link
Member Author

needs merging now as otherwise the call/ urls don't work anymore on latest master

Copy link
Member

@danxuliu danxuliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested (with nextcloud/server#20591) and works 👍

@nickvergessen
Copy link
Member Author

Merged now, so merging this

@nickvergessen
Copy link
Member Author

The integration tests is a failure on server master:

{
  "Exception": "OCP\\Files\\ForbiddenException",
  "Message": "Invalid path",
  "Code": 0,
  "Trace": [
    {
      "file": "/home/nickv/Nextcloud/19/server/lib/private/Files/Storage/Local.php",
      "line": 159,
      "function": "getSourcePath",
      "class": "OC\\Files\\Storage\\Local",
      "type": "->",
      "args": [
        "/.htaccess"
      ]
    },
    {
      "file": "/home/nickv/Nextcloud/19/server/lib/private/Files/Storage/Common.php",
      "line": 879,
      "function": "getMetaData",
      "class": "OC\\Files\\Storage\\Local",
      "type": "->",
      "args": [
        "/.htaccess"
      ]
    },
    {
      "function": "getDirectoryContent",
      "class": "OC\\Files\\Storage\\Common",
      "type": "->",
      "args": [
        ""
      ]
    },
    {
      "file": "/home/nickv/Nextcloud/19/server/lib/private/Files/Cache/Scanner.php",
      "line": 408,
      "function": "iterator_to_array",
      "args": [
        {
          "__class__": "Generator"
        }
      ]
    },
    {
      "file": "/home/nickv/Nextcloud/19/server/lib/private/Files/Cache/Scanner.php",
      "line": 388,
      "function": "handleChildren",
      "class": "OC\\Files\\Cache\\Scanner",
      "type": "->",
      "args": [
        "",
        false,
        3,
        16,
        true,
        0
      ]
    },
    {
      "file": "/home/nickv/Nextcloud/19/server/lib/private/Files/Cache/Scanner.php",
      "line": 340,
      "function": "scanChildren",
      "class": "OC\\Files\\Cache\\Scanner",
      "type": "->",
      "args": [
        "",
        false,
        3,
        16,
        true
      ]
    },
    {
      "file": "/home/nickv/Nextcloud/19/server/lib/private/Files/View.php",
      "line": 1338,
      "function": "scan",
      "class": "OC\\Files\\Cache\\Scanner",
      "type": "->",
      "args": [
        "",
        false
      ]
    },
    {
      "file": "/home/nickv/Nextcloud/19/server/lib/private/Files/View.php",
      "line": 1382,
      "function": "getCacheEntry",
      "class": "OC\\Files\\View",
      "type": "->",
      "args": [
        {
          "cache": {
            "__class__": "OC\\Files\\Cache\\Cache"
          },
          "scanner": {
            "__class__": "OC\\Files\\Cache\\Scanner"
          },
          "watcher": null,
          "propagator": null,
          "updater": null,
          "__class__": "OCA\\Files_Trashbin\\Storage"
        },
        "",
        ""
      ]
    },
    {
      "file": "/home/nickv/Nextcloud/19/server/lib/private/Files/Node/Node.php",
      "line": 100,
      "function": "getFileInfo",
      "class": "OC\\Files\\View",
      "type": "->",
      "args": [
        "/"
      ]
    },
    {
      "file": "/home/nickv/Nextcloud/19/server/lib/private/Files/Node/Node.php",
      "line": 342,
      "function": "getFileInfo",
      "class": "OC\\Files\\Node\\Node",
      "type": "->",
      "args": []
    },
    {
      "file": "/home/nickv/Nextcloud/19/server/appsbabies/spreed/lib/Files/Util.php",
      "line": 206,
      "function": "isShared",
      "class": "OC\\Files\\Node\\Node",
      "type": "->",
      "args": []
    },
    {
      "file": "/home/nickv/Nextcloud/19/server/appsbabies/spreed/lib/Files/Util.php",
      "line": 133,
      "function": "getAnyDirectShareOfNodeAccessibleByUser",
      "class": "OCA\\Talk\\Files\\Util",
      "type": "->",
      "args": [
        {
          "__class__": "OC\\Files\\Node\\Root"
        },
        "participant1"
      ]
    },

So asking whether the root is shared, scans it and does boom when you try to scan .htaccess.... great fun
Regression from nextcloud/server#20232 (comment) (reverting that commit fixes it) so not directly related to talk => merging

@nickvergessen nickvergessen merged commit a05d075 into master Apr 22, 2020
@nickvergessen nickvergessen deleted the techdebt/noid/allow-some-apps-to-have-root-urls branch April 22, 2020 13:28
joshtrichards added a commit to nextcloud/server that referenced this pull request Aug 4, 2025
No longer needed from what I can tell since #20114 & nextcloud/spreed#3134

Signed-off-by: Josh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants