Defer sending the notifications when we interact multiple times #3743
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joas Schilling <[email protected]>
nickvergessen
force-pushed
the
techdebt/noid/deferrable-notification-apps
branch
from
176195b to
429305b
Compare
Signed-off-by: Joas Schilling <[email protected]>
nickvergessen
force-pushed
the
techdebt/noid/deferrable-notification-apps
branch
from
57f203d to
b8503d0
Compare
danxuliu
approved these changes
Jul 17, 2020
Member
danxuliu
left a comment
danxuliu
left a comment
There was a problem hiding this comment.
Tested and works 👍
Should the flushing be added to CheckHostedSignalingServer.php too?
I have noticed that when a conversation with several participants is created there is still one notification sent for each user, although the issue seems to be that an AddParticipantsEvent is emitted for each user instead of one containing all the users, so it is not related to these changes.
Member
Author
Since this is in a background job, I don't care too much. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.